Add option for forced tunneling through TRE's Firewall #4238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit c8d9dbc. ♻️ This comment has been updated with latest results. |
Open
4 tasks
marrobi
reviewed
Jan 2, 2025
…7-support-firewall-force-tunnel
tamirkamara
approved these changes
Jan 6, 2025
marrobi
reviewed
Jan 6, 2025
…om/yuvalyaron/AzureTRE into 4237-support-firewall-force-tunnel
There was a problem hiding this comment.
Copilot reviewed 5 out of 13 changed files in this pull request and generated 2 comments.
Files not reviewed (8)
- Makefile: Language not supported
- templates/shared_services/firewall/parameters.json: Language not supported
- templates/shared_services/firewall/template_schema.json: Language not supported
- templates/shared_services/firewall/terraform/firewall.tf: Language not supported
- templates/shared_services/firewall/terraform/routetable.tf: Language not supported
- templates/shared_services/firewall/terraform/variables.tf: Language not supported
- .github/workflows/build_validation_develop.yml: Evaluated as low risk
- .github/workflows/codeql-analysis.yml: Evaluated as low risk
…om/yuvalyaron/AzureTRE into 4237-support-firewall-force-tunnel
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12656391688 (with refid (in response to this comment from @yuvalyaron) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4237
What is being addressed
Added the option for force tunnel TRE's Firewall to an external firewall
How is this addressed
firewall_force_tunnel_ipparameter torp_bundle_values, when set, the following are created:After that, users have to manually connect TRE's VNet to the external firewall (e.g. through VNet Peering).