-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add header file to define cooperative matrices in spir-v #6720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@EpicJeanNoeMorissette FYI: You said you were interested in seeing this when it was ready to be made public. This will probably still go through some changes before it is merged, but this is the vision I have. |
Keenuts
reviewed
Jun 25, 2024
s-perron
commented
Jun 25, 2024
s-perron
commented
Jun 25, 2024
s-perron
commented
Jun 25, 2024
s-perron
commented
Jun 25, 2024
s-perron
commented
Jun 25, 2024
s-perron
commented
Jun 25, 2024
s-perron
commented
Jun 25, 2024
s-perron
commented
Jun 25, 2024
s-perron
commented
Jun 27, 2024
✅ With the latest revision this PR passed the C/C++ code formatter. |
s-perron
force-pushed
the
coop_matrix
branch
4 times, most recently
from
July 5, 2024 15:04
cf7be64
to
9546037
Compare
s-perron
force-pushed
the
coop_matrix
branch
2 times, most recently
from
July 18, 2024 12:54
c71eb29
to
1e0ddd0
Compare
s-perron
force-pushed
the
coop_matrix
branch
2 times, most recently
from
July 31, 2024 18:51
ec32d8a
to
1922a69
Compare
s-perron
force-pushed
the
coop_matrix
branch
3 times, most recently
from
August 21, 2024 17:30
64f4aa6
to
df118bc
Compare
s-perron
commented
Aug 21, 2024
s-perron
force-pushed
the
coop_matrix
branch
4 times, most recently
from
September 17, 2024 13:37
3028830
to
b5403c4
Compare
s-perron
force-pushed
the
coop_matrix
branch
4 times, most recently
from
September 20, 2024 19:47
e6b4314
to
9da60ed
Compare
Keenuts
approved these changes
Sep 25, 2024
Implements [HLSL spec proposal 0021](https://github.com/microsoft/hlsl-specs/blob/9c42e278961dbf5b77d7d18b1e7ba7f6c0856154/proposals/0021-vk-coop-matrix.md) This commit adds a header file to the HLSL Standard Header library to implement cooperative matrices for SPIR-V. See the proposal for the specifics of the interface, and design decisions.
s-perron
force-pushed
the
coop_matrix
branch
from
September 25, 2024 18:12
9da60ed
to
5518cd6
Compare
cassiebeckley
approved these changes
Sep 25, 2024
s-perron
force-pushed
the
coop_matrix
branch
from
September 25, 2024 18:23
9e1e0cd
to
a3daa2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr will introduce the HLSL standard header files. This will become the a
way to add new extensions to HLSL without having to make modifications to the
compiler.
This first example is a fairly complex example that demonstrates how to do a few
different things:
naturally enforce the validation rules. In this case, we might be more strict
than the spir-v validation, but I believe this is still usable.
OpCooperativeMatrixLengthKHR instruction does not have an interface that is
natural in a language like HLSL. However, we can define a function that is, and
have the backend, make small adjustments. These cases should be avoided as much
as possible.