[SPIRV] Simplify looking for input storage class #6968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function `DeclResultIdMapper::isInputStorageClass` tries to determine the storage class for the stage variable by looking at its SigPoint. This does not always work. This change simply looks at the storage class that is already associated with the variable, which should have been set when the StageVar was created. Fixes microsoft#6959
cassiebeckley
approved these changes
Oct 15, 2024
Keenuts
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
DeclResultIdMapper::isInputStorageClasstries todetermine the storage class for the stage variable by looking at its
SigPoint. This does not always work.
This change simply looks at the storage class that is already associated
with the variable, which should have been set when the StageVar was
created.
Fixes #6959