Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

existence proof that is_deriv isn't needed #7023

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

existence proof that is_deriv isn't needed #7023

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions utils/hct/hctdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ def __init__(self, name, **kwargs):
self.is_allowed = True # whether this instruction is allowed in a DXIL program
self.oload_types = "" # overload types if applicable
self.fn_attr = "" # attribute shorthands: rn=does not access memory,ro=only reads from memory,
self.is_deriv = False # whether this is some kind of derivative
self.is_gradient = False # whether this requires a gradient calculation
self.is_feedback = False # whether this is a sampler feedback op
self.is_wave = False # whether this requires in-wave, cross-lane functionality
Expand Down Expand Up @@ -5523,11 +5522,6 @@ def UFI(name, **mappings):
","
):
self.name_idx[i].is_gradient = True
for i in "DerivCoarseX,DerivCoarseY,DerivFineX,DerivFineY".split(","):
assert (
self.name_idx[i].is_gradient == True
), "all derivatives are marked as requiring gradients"
self.name_idx[i].is_deriv = True

# TODO - some arguments are required to be immediate constants in DXIL, eg resource kinds; add this information
# consider - report instructions that are overloaded on a single type, then turn them into non-overloaded version of that type
Expand Down