Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't force /Zi when using CMAKE_MSVC_DEBUG_INFORMATION_FORMAT #7041

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Don't force /Zi when using CMAKE_MSVC_DEBUG_INFORMATION_FORMAT #7041

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions cmake/modules/HandleLLVMOptions.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,9 +357,11 @@ if( MSVC )

# Change release to always build debug information out-of-line, but
# also enable Reference optimization, ie dead function elimination.
append("/Zi" CMAKE_CXX_FLAGS_RELEASE)
append("/DEBUG /OPT:REF" CMAKE_SHARED_LINKER_FLAGS_RELEASE)
append("/DEBUG /OPT:REF" CMAKE_EXE_LINKER_FLAGS_RELEASE)
if (NOT CMAKE_MSVC_DEBUG_INFORMATION_FORMAT)
append("/Zi" CMAKE_CXX_FLAGS_RELEASE)
append("/DEBUG /OPT:REF" CMAKE_SHARED_LINKER_FLAGS_RELEASE)
append("/DEBUG /OPT:REF" CMAKE_EXE_LINKER_FLAGS_RELEASE)
endif()

# HLSL Changes End

Expand Down
Loading