-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recurring time window filter #73
Open
zhiyuanliang-ms
wants to merge
8
commits into
main
Choose a base branch
from
zhiyuanliang/recurring-time-window
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 8 out of 18 changed files in this pull request and generated no suggestions.
Files not reviewed (10)
- package.json: Language not supported
- src/filter/TimeWindowFilter.ts: Evaluated as low risk
- src/featureManager.ts: Evaluated as low risk
- test/noFilters.test.ts: Evaluated as low risk
- test/featureManager.test.ts: Evaluated as low risk
- test/targetingFilter.test.ts: Evaluated as low risk
- src/index.ts: Evaluated as low risk
- src/filter/targetingFilter.ts: Evaluated as low risk
- src/filter/recurrence/validator.ts: Evaluated as low risk
- src/filter/utils.ts: Evaluated as low risk
Comments skipped due to low confidence (5)
src/filter/recurrence/evaluator.ts:32
- [nitpick] The function name 'FindPreviousRecurrence' should be in camelCase to maintain consistency with the rest of the codebase. Consider renaming it to 'findPreviousRecurrence'.
function FindPreviousRecurrence(time: Date, recurrenceSpec: RecurrenceSpec): RecurrenceState | undefined {
src/filter/recurrence/evaluator.ts:60
- [nitpick] The function name 'FindPreviousDailyRecurrence' should be in camelCase to maintain consistency with the rest of the codebase. Consider renaming it to 'findPreviousDailyRecurrence'.
function FindPreviousDailyRecurrence(time: Date, recurrenceSpec: RecurrenceSpec): RecurrenceState {
src/filter/recurrence/evaluator.ts:43
- The error message 'Unsupported recurrence pattern type.' could be more specific. Consider providing the unsupported pattern type in the message.
throw new Error("Unsupported recurrence pattern type.");
src/filter/timeWindowFilter.ts:21
- [nitpick] The type name 'RecurrenceParameter' is inconsistent with the naming convention of other parameter types. Consider renaming it to 'RecurrenceParameters'.
export type RecurrenceParameter = {
src/filter/recurrence/utils.ts:34
- [nitpick] The parameter name 'timezoneOffset' is ambiguous as it is in milliseconds. Consider renaming it to 'timezoneOffsetInMs' or adding a comment to clarify.
export function getDayOfWeek(date: Date, timezoneOffset: number): number {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
Support recurrence for time window filter. Also renamed some files to follow the naming convention.
Time window filter schema: https://github.com/microsoft/FeatureManagement/blob/main/Schema/FeatureFilters/Microsoft.TimeWindow.v2.0.0.schema.json
Reference:
#266
#522
Doc