-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tutorial Part 1 to MV3 #202
Update tutorial Part 1 to MV3 #202
Conversation
@bhuvanapriyap pls review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved - LGTM - PM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Writer/Editor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving the code changes. They help make things clearer, and easier to differentiate the part 1 and part 2 extension samples. It's also very important to move to MV3, since that's what articles on learn.microsoft.com document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Dev
This PR makes the following changes:
"manifest_version": 2,
to"manifest_version": 3,
"browser_action": {
to:"action": {
name
string to be different from Part 2.description
string to be different than Part 2, and described the type of functionality.manifest.json
, changeddescription
string to be different than Part 1, and described the type of functionality.Related PR:
MicrosoftDocs/edge-developer#3277
AB#54220337