Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorial Part 1 to MV3 #202

Merged
merged 13 commits into from
Oct 25, 2024

Conversation

mikehoffms
Copy link
Contributor

@mikehoffms mikehoffms commented Sep 25, 2024

This PR makes the following changes:

  • README for the repo
  • Part 1 sample
    • Copied manifest.json code listing from article https://learn.microsoft.com/microsoft-edge/extensions-chromium/getting-started/part1-simple-extension?tabs=v3#step-3-open-a-default-pop-up-dialog (from PR 3277's version of the article).
      • Changed "manifest_version": 2, to "manifest_version": 3,
      • Changed key name from "browser_action": { to: "action": {
      • Changed capitalization to match the article.
      • Changed name string to be different from Part 2.
        • To avoid displaying identical names for the two very different completed demos in the Extensions list & in the Manage Extensions page.
        • When 1 & 2 are both installed, need a way to tell which is which, in the Extensions list.
      • Changed description string to be different than Part 2, and described the type of functionality.
        • To prevent identical descriptions for the two very different completed demos in the Manage Extensions page.
        • When 1 & 2 are both installed, need a way to tell which is which, in the Manage Extensions page..
        • The two demos are very different and need distinctive descriptions of the different functionality.
    • These changes have been tested; installed and ran this modified demo from local dir branch of this repo; demo ran ok, per screenshots of it.
  • Part 2 sample
    • Copied Part 2 code in text files from Part 2 article per PR 3277 over the existing listings.
      • To make leading spaces same between article & samples repo.
      • To update casing/ capitalization within strings.
      • To have a differentiated manifest "name" and "description" field.
    • In manifest.json, changed description string to be different than Part 1, and described the type of functionality.
    • These changes have been tested; installed and ran this modified demo from local dir branch of this repo; demo ran ok, per screenshots of it.

Related PR:
MicrosoftDocs/edge-developer#3277

AB#54220337

@mikehoffms
Copy link
Contributor Author

mikehoffms commented Sep 25, 2024

@bhuvanapriyap pls review.
To approve the PR: Files changed page > Review changes green button > Approve option button along with a comment, "LGTM - PM".

Copy link

@bhuvanapriyap bhuvanapriyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - LGTM - PM

Copy link
Contributor Author

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Writer/Editor

Copy link

@captainbrosset captainbrosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving the code changes. They help make things clearer, and easier to differentiate the part 1 and part 2 extension samples. It's also very important to move to MV3, since that's what articles on learn.microsoft.com document.

Copy link

@yvsubhash yvsubhash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Dev

@sivMSFT sivMSFT merged commit f551507 into microsoft:main Oct 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants