Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change udf vec2array to pyspark.ml.functions.vector_to_array #2131

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

memoryz
Copy link
Contributor

@memoryz memoryz commented Nov 13, 2023

What changes are proposed in this pull request?

vector_to_array was introduced in Spark 3.0 which replaces the need for udf vec2array.

How is this patch tested?

  • Through notebook test automation
  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.
  1. Find the corresponding markdown file for your new feature in website/docs/documentation folder.
    Make sure you choose the correct class estimators/transformers and namespace.
  2. Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
  3. Make sure the DocTable points to correct API link.
  4. Navigate to website folder, and run yarn run start to make sure the website renders correctly.
  5. Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
  6. Make sure the WebsiteSamplesTests job pass in the pipeline.

Copy link

Hey @memoryz 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.

We use semantic commit messages to streamline the release process.
Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix.
This helps us to create release messages and credit you for your hard work!

Examples of commit messages with semantic prefixes:

  • fix: Fix LightGBM crashes with empty partitions
  • feat: Make HTTP on Spark back-offs configurable
  • docs: Update Spark Serving usage
  • build: Add codecov support
  • perf: improve LightGBM memory usage
  • refactor: make python code generation rely on classes
  • style: Remove nulls from CNTKModel
  • test: Add test coverage for CNTKModel

To test your commit locally, please follow our guild on building from source.
Check out the developer guide for additional guidance on testing your change.

@memoryz memoryz marked this pull request as ready for review November 13, 2023 00:12
@memoryz
Copy link
Contributor Author

memoryz commented Nov 13, 2023

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46a1ef8) 86.15% compared to head (0492f43) 86.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2131      +/-   ##
==========================================
+ Coverage   86.15%   86.18%   +0.02%     
==========================================
  Files         312      312              
  Lines       16477    16477              
  Branches     1460     1460              
==========================================
+ Hits        14196    14200       +4     
+ Misses       2281     2277       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhamilton723
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@memoryz memoryz enabled auto-merge (squash) November 16, 2023 06:22
@memoryz
Copy link
Contributor Author

memoryz commented Nov 16, 2023

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@memoryz memoryz merged commit 28cd6db into microsoft:master Nov 16, 2023
67 checks passed
@memoryz memoryz deleted the jasowang/vec2array branch November 16, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants