-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial push for adding orchestration reuse ID #258
Draft
RyanLettieri
wants to merge
7
commits into
microsoft:main
Choose a base branch
from
RyanLettieri:reuse-id
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e3c1304
Initial push for adding orchestration reuse ID
RyanLettieri 47c5446
Updating proto
RyanLettieri d44e411
Updating proto again
RyanLettieri 4fa6141
Including proto definitions and moving reuseID into options
RyanLettieri 4e7de08
Creating abstraction for runtime status and orchestration action enum
RyanLettieri 81b993a
Fixing ID Reuse Policy
RyanLettieri 5a79b5c
Merge branch 'microsoft:main' into reuse-id
RyanLettieri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,6 +27,7 @@ public interface IOrchestrationSubmitter | |
/// The optional input to pass to the scheduled orchestration instance. This must be a serializable value. | ||
/// </param> | ||
/// <param name="options">The options to start the new orchestration with.</param> | ||
/// <param name="orchestrationIdReusePolicy">The policy for reusing an orchestration ID.</param> | ||
/// <param name="cancellation"> | ||
/// The cancellation token. This only cancels enqueueing the new orchestration to the backend. Does not cancel the | ||
/// orchestration once enqueued. | ||
|
@@ -40,5 +41,6 @@ Task<string> ScheduleNewOrchestrationInstanceAsync( | |
TaskName orchestratorName, | ||
object? input = null, | ||
StartOrchestrationOptions? options = null, | ||
HashSet<string>? orchestrationIdReusePolicy = null, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "ReusePolicy" isn't that clear to me. Was the name |
||
CancellationToken cancellation = default); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -73,6 +73,7 @@ public override async Task<string> ScheduleNewOrchestrationInstanceAsync( | |
TaskName orchestratorName, | ||
object? input = null, | ||
StartOrchestrationOptions? options = null, | ||
HashSet<string>? orchestrationIdReusePolicy = null, | ||
CancellationToken cancellation = default) | ||
{ | ||
Check.NotEntity(this.options.EnableEntitySupport, options?.InstanceId); | ||
|
@@ -83,6 +84,7 @@ public override async Task<string> ScheduleNewOrchestrationInstanceAsync( | |
Version = orchestratorName.Version, | ||
InstanceId = options?.InstanceId ?? Guid.NewGuid().ToString("N"), | ||
Input = this.DataConverter.Serialize(input), | ||
OrchestrationIdReusePolicy = { }, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You need to map this from |
||
}; | ||
|
||
DateTimeOffset? startAt = options?.StartAt; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this to
StartOrchestrationOptions
instead of its own parameter. All non-essential parameters for affecting orchestration start should go there.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, should this be an enum with the available behaviors as values in it?