Add parent trace context information when scheduling an orchestration #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jviau
requested changes
Dec 17, 2024
| @@ -100,4 +100,5 @@ public SubOrchestrationOptions(TaskOptions options, string? instanceId = null) | |||
| /// The time when the orchestration instance should start executing. If not specified or if a date-time in the past | |||
| /// is specified, the orchestration instance will be scheduled immediately. | |||
| /// </param> | |||
| public record StartOrchestrationOptions(string? InstanceId = null, DateTimeOffset? StartAt = null); | |||
| /// <param name="ParentTraceId">Parent Trace Id.</param> | |||
| public record StartOrchestrationOptions(string? InstanceId = null, DateTimeOffset? StartAt = null, string? ParentTraceId = null); | |||
There was a problem hiding this comment.
We should not include trace information in the public API. Capturing of trace details should be done implicitly in the implementation by checking Activity.Current.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes send trace context information about the client function when scheduling the orchestration. The parent's traceId is sent through
StartOrchestrationOptions.