chore(react-provider): Updating FluentProvider types to avoid implicit import in API definition
#33590
+40
−182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khmakoto
changed the title
react-provider): Updating FluentProvider types to avoid implicit import in API definition
📊 Bundle size report
🤖 This report was generated against 95af8ed946f334198a8d26c3ae939dab1163911d |
|
Pull request demo site: URL |
fabricteam
reviewed
Jan 9, 2025
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv9 Visual Regression Report
Avatar Converged 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar Converged.Badge Mask RTL.chromium.png | 4 | Changed |
| Avatar Converged.badgeMask.chromium.png | 41 | Changed |
Drawer 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Drawer.Full Overlay High Contrast.chromium.png | 2247 | Changed |
| Drawer.Full Overlay RTL.chromium.png | 1167 | Changed |
…hore/react-provider/correctTypings
spmonahan
reviewed
Jan 9, 2025
| @@ -1,17 +1,21 @@ | |||
| import * as React from 'react'; | |||
| import { ForwardRefComponent } from '@fluentui/react-utilities'; | |||
There was a problem hiding this comment.
Suggested change
| import { ForwardRefComponent } from '@fluentui/react-utilities'; | |
| import type { ForwardRefComponent } from '@fluentui/react-utilities'; |
spmonahan
approved these changes
Jan 9, 2025
|
We should wait until #33599 is merged so that API related failures in other packages go away. |
khmakoto
requested review from
mltejera,
a team and
Mitch-At-Work
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Because of type expansion due to inference of the
FluentProvider, the API definition for@fluentui/react-providerincluded an implicit import of@fluentui/tokens.New Behavior
By adding an explicit type of
ForwardRefComponent<FluentProviderProps>toFluentProvider, we remove the implicit reference to@fluentui/tokensin the API file.Related Issue(s)
@fluentui/react-providerreferences a non-dependency #33189