Skip to content

Commit

Permalink
Update dependencies and ability to pass in compile version
Browse files Browse the repository at this point in the history
  • Loading branch information
karianna committed Dec 27, 2023
1 parent 76d1fbe commit b9e03c0
Show file tree
Hide file tree
Showing 5 changed files with 28 additions and 27 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/maven.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@ jobs:
cache: 'maven'

- name: Build with Maven
run: ./mvnw -B verify --file pom.xml
run: ./mvnw -B verify -Dmaven.compiler.release=${{ matrix.java }} --file pom.xml
12 changes: 6 additions & 6 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,25 +16,25 @@ or contact [[email protected]](mailto:[email protected]) with any addi
## Submit an Issue

if you wish to contribute to GCToolKit we would kindly ask that you submit an issue to the issue tracker. Doing so will help with the management of the project.

## Build

The build requires JDK 11, and uses the Maven wrapper (`mvnw`) to help ensure reproducible builds and so we don't force you to change your system Maven install. If you prefer to build with your local Maven installation, make sure the version matches the one in the project's [.mvn/wrapper/maven-wrapper.properties](https://github.com/microsoft/gctoolkit/blob/main/.mvn/wrapper/maven-wrapper.properties) file.
The build requires JDK 11 (you can also use JDK 17 or 21), and uses the Maven wrapper (`mvnw`) to help ensure reproducible builds and so we don't force you to change your system Maven install. If you prefer to build with your local Maven installation, make sure the version matches the one in the project's [.mvn/wrapper/maven-wrapper.properties](https://github.com/microsoft/gctoolkit/blob/main/.mvn/wrapper/maven-wrapper.properties) file.

* `mvnw clean` - remove build artifacts
* `mvnw compile` - compile the source code
* `./mvnw clean` - remove build artifacts
* `./mvnw compile |17>` - compile the source code. WARN you must set `11` or `17` for the release version.

## Test

You can execute test cases with following command.

* `mvnw test` - run unit tests (this project uses JUnit 5)
* `./mvnw test -Dmaven.compiler.release=<11|17>` - run unit tests (this project uses JUnit 5)

## Package

The packaging is vanilla Maven.

* `mvnw package` - create the binaries.
* `mvnw package -Dmaven.compiler.release=<11|17>` - create the binaries.

## Deploy / Publish

Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,19 +35,19 @@ The GCToolKit artifacts are in [Maven Central](https://search.maven.org/search?q
<dependency>
<groupId>com.microsoft.gctoolkit</groupId>
<artifactId>api</artifactId>
<version>3.0.0</version>
<version>3.0.4</version>
</dependency>

<dependency>
<groupId>com.microsoft.gctoolkit</groupId>
<artifactId>parser</artifactId>
<version>3.0.0</version>
<version>3.0.4</version>
</dependency>

<dependency>
<groupId>com.microsoft.gctoolkit</groupId>
<artifactId>vertx</artifactId>
<version>3.0.0</version>
<version>3.0.4</version>
</dependency>

...
Expand Down
33 changes: 17 additions & 16 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -56,42 +56,43 @@

<properties>
<revision>3.0.3-SNAPSHOT</revision>
<checkstyle.version>10.12.4</checkstyle.version>
<jreleaser.plugin.version>1.7.0</jreleaser.plugin.version>
<junit5.version>5.10.0</junit5.version>
<checkstyle.version>10.12.6</checkstyle.version>
<jreleaser.plugin.version>1.9.0</jreleaser.plugin.version>
<junit5.version>5.10.1</junit5.version>
<maven.antrun-plugin.version>3.1.0</maven.antrun-plugin.version>
<maven.changes-plugin.version>2.12.1</maven.changes-plugin.version>
<maven.checkstyle-plugin.version>3.3.1</maven.checkstyle-plugin.version>
<maven.clean-plugin.version>3.3.2</maven.clean-plugin.version>
<maven.compiler-plugin.version>3.11.0</maven.compiler-plugin.version>
<maven.compiler.release>17</maven.compiler.release>
<maven.compiler-plugin.version>3.12.1</maven.compiler-plugin.version>
<!-- Commented out as we pass this parameter in so we can execute a matrix of builds -->
<!-- <maven.compiler.release>17</maven.compiler.release> -->
<maven.dependency-plugin.version>3.6.1</maven.dependency-plugin.version>
<maven.deploy-plugin.version>3.1.1</maven.deploy-plugin.version>
<maven.directory-maven-plugin.version>1.0</maven.directory-maven-plugin.version>
<maven.enforcer-plugin.version>3.4.1</maven.enforcer-plugin.version>
<maven.exec-plugin.version>3.1.0</maven.exec-plugin.version>
<maven.exec-plugin.version>3.1.1</maven.exec-plugin.version>
<maven.install-plugin.version>3.1.1</maven.install-plugin.version>
<maven.jacoco-plugin.version>0.8.11</maven.jacoco-plugin.version>
<maven.jar-plugin.version>3.3.0</maven.jar-plugin.version>
<maven.javadoc-plugin.version>3.6.0</maven.javadoc-plugin.version>
<maven.javadoc-plugin.version>3.6.3</maven.javadoc-plugin.version>
<maven.jxr-plugin.version>3.3.1</maven.jxr-plugin.version>
<maven.license-plugin.version>2.3.0</maven.license-plugin.version>
<maven.pmd-plugin.version>3.21.0</maven.pmd-plugin.version>
<maven.project-info-reports-plugin.version>3.4.5</maven.project-info-reports-plugin.version>
<maven.pmd-plugin.version>3.21.2</maven.pmd-plugin.version>
<maven.project-info-reports-plugin.version>3.5.0</maven.project-info-reports-plugin.version>
<maven.rat-plugin.version>0.15</maven.rat-plugin.version>
<maven.resources-plugin.version>3.3.1</maven.resources-plugin.version>
<maven.site-plugin.version>4.0.0-M11</maven.site-plugin.version>
<maven.site-plugin.version>4.0.0-M13</maven.site-plugin.version>
<maven.source-plugin.version>3.3.0</maven.source-plugin.version>
<maven.spotbugs-plugin.version>4.7.3.6</maven.spotbugs-plugin.version>
<maven.surefire-plugin.version>3.2.1</maven.surefire-plugin.version>
<maven.spotbugs-plugin.version>4.8.2.0</maven.spotbugs-plugin.version>
<maven.surefire-plugin.version>3.2.3</maven.surefire-plugin.version>
<maven.version>3.9.5</maven.version>
<maven.versions-plugin.version>2.16.1</maven.versions-plugin.version>
<mutability.detector.version>0.9.1</mutability.detector.version>
<pmd.version>6.55.0</pmd.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.github.repository>microsoft/gctoolkit</project.github.repository>
<repository.url>[email protected]:${project.github.repository}.git</repository.url>
<spotbugs.version>4.8.0</spotbugs.version>
<spotbugs.version>4.8.3</spotbugs.version>
</properties>

<modules>
Expand Down Expand Up @@ -195,8 +196,8 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>${maven.compiler-plugin.version}</version>
<configuration>
<source>17</source>
<target>17</target>
<source>{maven.compiler.release}</source>
<target>{maven.compiler.release}</target>
<compilerArgs>
<arg>--module-version=${project.version}</arg>
<arg>-Xlint:unchecked</arg>
Expand Down Expand Up @@ -389,7 +390,7 @@
<plugin>
<groupId>org.hjug.refactorfirst.plugin</groupId>
<artifactId>refactor-first-maven-plugin</artifactId>
<version>0.4.0</version>
<version>0.5.0-M1</version>
<!-- optional -->
<configuration>
<showDetails>true</showDetails>
Expand Down
2 changes: 1 addition & 1 deletion vertx/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<dependency>
<groupId>io.vertx</groupId>
<artifactId>vertx-core</artifactId>
<version>4.4.6</version>
<version>4.5.1</version>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
Expand Down

0 comments on commit b9e03c0

Please sign in to comment.