Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.sync/workflows/leaf/codeql.yml: Update CodeQL plugin from .pytool to BaseTools #299

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

makubacki
Copy link
Member

@makubacki makubacki commented Jan 22, 2024

The CodeQL plugin moved from .pytool to BaseTools in the Mu Basecore 202311 update. This change first looks for the plugin in BaseTools and falls back to the prior .pytool location if it is not found for backward compatibility with some earlier release branches that have not picked up the change.

Eventually, the .pytool fallback can be removed.


Issue to track removal of the fallback: #300

@makubacki makubacki added the type:design-change A new proposal or modification to a feature design label Jan 22, 2024
@makubacki makubacki requested review from kenlautner and apop5 January 22, 2024 22:03
@makubacki makubacki self-assigned this Jan 22, 2024
… BaseTools

The CodeQL plugin moved from .pytool to BaseTools in the Mu Basecore
202311 update. This change first looks for the plugin in BaseTools
and falls back to the prior .pytool location if it is not found for
backward compatibility with some earlier release branches that have
not picked up the change.

Eventually, the .pytool fallback can be removed.

Signed-off-by: Michael Kubacki <[email protected]>
@makubacki makubacki force-pushed the use_codeql_from_basetools branch from fd5324c to 0d94bf8 Compare January 22, 2024 22:07
@makubacki makubacki enabled auto-merge (squash) January 22, 2024 22:36
@makubacki makubacki merged commit fbb8ff6 into microsoft:main Jan 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:design-change A new proposal or modification to a feature design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants