Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chromium-tip-of-tree): roll to r1232 #31362

Closed

Conversation

playwrightmachine
Copy link
Collaborator

@playwrightmachine playwrightmachine commented Jun 18, 2024

Good:

#      CURRENT_VERSION: 128.0.6536.0
# BRANCH_BASE_POSITION: 1314318
BRANCH_COMMIT="11d56f88594ff95c8e34acabd4893e9a1d431cf1"

Bad:

#      CURRENT_VERSION: 128.0.6543.0
# BRANCH_BASE_POSITION: 1316206
BRANCH_COMMIT="6c15c08c7ff32fc9bf8899b07f7f56789fb8f3bc"

Failing PR: #31362

Failing tests:

    [chromium-library] › library/browsercontext-credentials.spec.ts:27:1 › should fail without credentials 
    [chromium-library] › library/browsercontext-credentials.spec.ts:41:1 › should work with setHTTPCredentials 
    [chromium-library] › library/browsercontext-credentials.spec.ts:112:1 › should fail with correct credentials and mismatching scheme 
    [chromium-library] › library/browsercontext-credentials.spec.ts:124:1 › should fail with correct credentials and mismatching hostname 
    [chromium-library] › library/browsercontext-credentials.spec.ts:138:1 › should fail with correct credentials and mismatching port 
    [chromium-library] › library/download.spec.ts:641:3 › should be able to download a inline PDF file via navigation 
    [chromium-library] › library/emulation-focus.spec.ts:104:3 › should not affect screenshots ─────
    [chromium-library] › library/permissions.spec.ts:153:3 › should support clipboard read ─────────
    [chromium-library] › library/tracing.spec.ts:412:14 › should produce screencast frames fit ─────
    [chromium-library] › library/tracing.spec.ts:412:14 › should produce screencast frames crop ────
    [chromium-library] › library/tracing.spec.ts:412:14 › should produce screencast frames scale ───
    [chromium-library] › library/video.spec.ts:446:5 › screencast › should scale frames down to the requested size  
    [chromium-library] › library/video.spec.ts:695:5 › screencast › should capture full viewport ───
    [chromium-library] › library/video.spec.ts:730:5 › screencast › should capture full viewport on hidpi 
    [chromium-library] › library/video.spec.ts:767:5 › screencast › should work with video+trace ───

Bisect 1 (library/browsercontext-credentials.spec.ts:27:1):

Command: npx bisect-chrome --good 1314318 --bad 1316206 --shell "npm run ctest -- --reporter=list library/browsercontext-credentials.spec.ts:27:1"

RANGE: https://chromium.googlesource.com/chromium/src/+log/fadb61567ce2a7f1bcc181ce65e000d56064fe8d..1f24a69d69b03bc83a26bed4c236e397d6ba44c2

Commit: https://chromium.googlesource.com/chromium/src/+/b9b39a430f71c710d16aafcc67278ef77440c18d

Resolution: --headless -> --headless=old

This causes crashes with:

  pw:browser [pid=101511][err] #3 0x60415dc99040 [0619/085814.809447:ERROR:render_process_host_impl.cc(5571)] Terminating render process for bad Mojo message: Received bad user message: No binder found for interface translate.mojom.ContentTranslateDriver for the frame/document scope +1ms

Minimal repro is:

 /ms-playwright/chromium_tip_of_tree-1232/chrome-linux/chrome --no-sandbox --headless=old --screenshot=foo.png https://github.com

Filed as https://issues.chromium.org/u/1/issues/348031037

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@mxschmitt mxschmitt added CQ1 and removed CQ1 labels Jun 18, 2024
Copy link
Contributor

Test results for "tests 1"

1 fatal errors, not part of any test
53 failed
❌ [playwright-test] › playwright.ct-build.spec.ts:361:5 › should not use global config for preview
❌ [playwright-test] › playwright.ct-build.spec.ts:421:5 › list compilation cache should not clash with the run one
❌ [playwright-test] › playwright.ct-build.spec.ts:513:5 › should render component via re-export
❌ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page
❌ [chromium-library] › library/beforeunload.spec.ts:30:3 › should close browsercontext with beforeunload page
❌ [chromium-library] › library/beforeunload.spec.ts:38:3 › should be able to navigate away from page with beforeunload
❌ [chromium-library] › library/beforeunload.spec.ts:46:3 › should close page with beforeunload listener
❌ [chromium-library] › library/beforeunload.spec.ts:55:3 › should run beforeunload if asked for @smoke
❌ [chromium-library] › library/beforeunload.spec.ts:79:3 › should access page after beforeunload
❌ [chromium-library] › library/beforeunload.spec.ts:92:3 › should not stall on evaluate when dismissing beforeunload
❌ [chromium-library] › library/browser.spec.ts:24:5 › should create new page @smoke
❌ [chromium-library] › library/browser.spec.ts:38:5 › should throw upon second create new page
❌ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:22:3 › should work @smoke
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:32:3 › should work with expires=-1
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:50:3 › should add cookies with empty value
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:68:3 › should roundtrip cookie
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:87:3 › should send cookie header
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:99:3 › should isolate cookies in browser contexts
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:115:3 › should isolate session cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:141:3 › should isolate persistent cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:161:3 › should isolate send cookie header
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:182:15 › should isolate cookies between launches
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:197:3 › should set multiple cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:217:3 › should have |expires| set to |-1| for session cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:227:3 › should set cookie with reasonable defaults
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:246:3 › should set a cookie with a path
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:297:3 › should default to setting secure cookie for HTTPS websites
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:309:3 › should be able to set unsecure cookie for HTTP website
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:321:3 › should set a cookie on a different domain
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:342:3 › should set cookies for a frame
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:360:3 › should(not) block third party cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:392:3 › should not block third party SameSite=None cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:429:3 › should allow unnamed cookies
❌ [chromium-library] › library/browsercontext-add-init-script.spec.ts:20:3 › should work with browser context scripts @smoke
❌ [chromium-library] › library/browsercontext-add-init-script.spec.ts:28:3 › should work without navigation, after all bindings
❌ [chromium-library] › library/browsercontext-add-init-script.spec.ts:45:3 › should work without navigation in popup
❌ [chromium-library] › library/browsercontext-add-init-script.spec.ts:55:3 › should work with browser context scripts with a path
❌ [chromium-library] › library/browsercontext-add-init-script.spec.ts:62:3 › should work with browser context scripts for already created pages
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:20:3 › should construct a new URL when a baseURL in browser.newContext is passed to page.goto @smoke
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:29:3 › should construct a new URL when a baseURL in browser.newPage is passed to page.goto
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:47:3 › should construct the URLs correctly when a baseURL without a trailing slash in browser.newPage is passed to page.goto
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:57:3 › should construct the URLs correctly when a baseURL with a trailing slash in browser.newPage is passed to page.goto
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:69:3 › should not construct a new URL when valid URLs are passed
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:83:3 › should be able to match a URL relative to its given URL with urlMatcher
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:105:3 › should not construct a new URL with baseURL when a glob was used
❌ [chromium-library] › library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts
❌ [chromium-library] › library/browsercontext-basic.spec.ts:70:3 › window.open should use parent tab context
❌ [chromium-library] › library/browsercontext-basic.spec.ts:82:3 › should isolate localStorage and cookies @smoke
❌ [chromium-library] › library/browsercontext-basic.spec.ts:134:3 › should make a copy of default viewport
❌ [chromium-library] › library/browsercontext-basic.spec.ts:143:3 › should respect deviceScaleFactor
❌ [chromium-library] › library/browsercontext-basic.spec.ts:188:3 › should not report frameless pages on error

3 flaky ⚠️ [playwright-test] › ui-mode-test-screencast.spec.ts:21:5 › should show screenshots
⚠️ [chromium-library] › library/browsercontext-basic.spec.ts:127:3 › should propagate default viewport to the page
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all
1 interrupted ⚠️ [chromium-library] › library/browsercontext-add-cookies.spec.ts:458:3 › should set secure cookies on secure WebSocket

24722 passed, 568 skipped, 3648 did not run
✔️✔️✔️

Merge workflow run.

Copy link
Contributor

Test results for "tests others"

2 failed
❌ [playwright-test] › reporter-html.spec.ts:296:5 › created › should include image diff when screenshot failed to generate due to animation
❌ [playwright-test] › ui-mode-test-setup.spec.ts:217:9 › web-mode: true › should run teardown with SIGINT

2 flaky ⚠️ [electron-api] › electron/electron-app.spec.ts:55:5 › should fire close event when the app quits itself
⚠️ [electron-page] › page/page-route.spec.ts:417:3 › should work with redirects for subresources

17637 passed, 589 skipped
✔️✔️✔️

Merge workflow run.

Copy link
Contributor

Test results for "tests 2"

8 fatal errors, not part of any test
235 failed
❌ [chromium-page] › page/page-screenshot.spec.ts:283:5 › page screenshot › should work for canvas
❌ [chromium-page] › page/page-screenshot.spec.ts:283:5 › page screenshot › should work for canvas
❌ [chromium-page] › page/page-screenshot.spec.ts:283:5 › page screenshot › should work for canvas
❌ [chromium-page] › page/page-screenshot.spec.ts:283:5 › page screenshot › should work for canvas
❌ [chromium-page] › page/page-screenshot.spec.ts:283:5 › page screenshot › should work for canvas
❌ [chromium-library] › library/debug-controller.spec.ts:70:1 › should pick element
❌ [chromium-library] › library/debug-controller.spec.ts:99:1 › should report pages
❌ [chromium-library] › library/debug-controller.spec.ts:127:1 › should navigate all
❌ [chromium-library] › library/debug-controller.spec.ts:138:1 › should reset for reuse
❌ [chromium-library] › library/debug-controller.spec.ts:150:1 › should highlight all
❌ [chromium-library] › library/debug-controller.spec.ts:163:1 › should record
❌ [chromium-library] › library/debug-controller.spec.ts:198:1 › should record custom data-testid
❌ [chromium-library] › library/debug-controller.spec.ts:233:1 › should reset routes before reuse
❌ [chromium-library] › library/headful.spec.ts:288:3 › headless and headful should use same default fonts
❌ [chromium-page] › page/page-screenshot.spec.ts:283:5 › page screenshot › should work for canvas
❌ [chromium-library] › library/debug-controller.spec.ts:70:1 › should pick element
❌ [chromium-library] › library/debug-controller.spec.ts:99:1 › should report pages
❌ [chromium-library] › library/debug-controller.spec.ts:127:1 › should navigate all
❌ [chromium-library] › library/debug-controller.spec.ts:138:1 › should reset for reuse
❌ [chromium-library] › library/debug-controller.spec.ts:150:1 › should highlight all
❌ [chromium-library] › library/debug-controller.spec.ts:163:1 › should record
❌ [chromium-library] › library/debug-controller.spec.ts:198:1 › should record custom data-testid
❌ [chromium-library] › library/debug-controller.spec.ts:233:1 › should reset routes before reuse
❌ [chromium-library] › library/headful.spec.ts:288:3 › headless and headful should use same default fonts
❌ [chromium-library] › library/debug-controller.spec.ts:70:1 › should pick element
❌ [chromium-library] › library/debug-controller.spec.ts:99:1 › should report pages
❌ [chromium-library] › library/debug-controller.spec.ts:127:1 › should navigate all
❌ [chromium-library] › library/debug-controller.spec.ts:138:1 › should reset for reuse
❌ [chromium-library] › library/debug-controller.spec.ts:150:1 › should highlight all
❌ [chromium-library] › library/debug-controller.spec.ts:163:1 › should record
❌ [chromium-library] › library/debug-controller.spec.ts:198:1 › should record custom data-testid
❌ [chromium-library] › library/debug-controller.spec.ts:233:1 › should reset routes before reuse
❌ [chromium-library] › library/headful.spec.ts:288:3 › headless and headful should use same default fonts
❌ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page
❌ [chromium-library] › library/beforeunload.spec.ts:30:3 › should close browsercontext with beforeunload page
❌ [chromium-library] › library/beforeunload.spec.ts:38:3 › should be able to navigate away from page with beforeunload
❌ [chromium-library] › library/beforeunload.spec.ts:46:3 › should close page with beforeunload listener
❌ [chromium-library] › library/beforeunload.spec.ts:55:3 › should run beforeunload if asked for @smoke
❌ [chromium-library] › library/beforeunload.spec.ts:79:3 › should access page after beforeunload
❌ [chromium-library] › library/beforeunload.spec.ts:92:3 › should not stall on evaluate when dismissing beforeunload
❌ [chromium-library] › library/browser.spec.ts:24:5 › should create new page @smoke
❌ [chromium-library] › library/browser.spec.ts:38:5 › should throw upon second create new page
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:22:3 › should work @smoke
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:32:3 › should work with expires=-1
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:50:3 › should add cookies with empty value
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:68:3 › should roundtrip cookie
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:87:3 › should send cookie header
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:115:3 › should isolate session cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:141:3 › should isolate persistent cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:161:3 › should isolate send cookie header
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:197:3 › should set multiple cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:246:3 › should set a cookie with a path
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:297:3 › should default to setting secure cookie for HTTPS websites
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:309:3 › should be able to set unsecure cookie for HTTP website
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:321:3 › should set a cookie on a different domain
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:342:3 › should set cookies for a frame
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:360:3 › should(not) block third party cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:392:3 › should not block third party SameSite=None cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:429:3 › should allow unnamed cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:458:3 › should set secure cookies on secure WebSocket
❌ [chromium-library] › library/browsercontext-add-init-script.spec.ts:20:3 › should work with browser context scripts @smoke
❌ [chromium-library] › library/browsercontext-add-init-script.spec.ts:28:3 › should work without navigation, after all bindings
❌ [chromium-library] › library/browsercontext-add-init-script.spec.ts:45:3 › should work without navigation in popup
❌ [chromium-library] › library/browsercontext-add-init-script.spec.ts:55:3 › should work with browser context scripts with a path
❌ [chromium-library] › library/browsercontext-add-init-script.spec.ts:62:3 › should work with browser context scripts for already created pages
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:20:3 › should construct a new URL when a baseURL in browser.newContext is passed to page.goto @smoke
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:29:3 › should construct a new URL when a baseURL in browser.newPage is passed to page.goto
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:47:3 › should construct the URLs correctly when a baseURL without a trailing slash in browser.newPage is passed to page.goto
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:57:3 › should construct the URLs correctly when a baseURL with a trailing slash in browser.newPage is passed to page.goto
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:69:3 › should not construct a new URL when valid URLs are passed
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:83:3 › should be able to match a URL relative to its given URL with urlMatcher
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:105:3 › should not construct a new URL with baseURL when a glob was used
❌ [chromium-library] › library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts
❌ [chromium-library] › library/browsercontext-basic.spec.ts:70:3 › window.open should use parent tab context
❌ [chromium-library] › library/browsercontext-basic.spec.ts:82:3 › should isolate localStorage and cookies @smoke
❌ [chromium-library] › library/browsercontext-basic.spec.ts:127:3 › should propagate default viewport to the page
❌ [chromium-library] › library/browsercontext-basic.spec.ts:134:3 › should make a copy of default viewport
❌ [chromium-library] › library/browsercontext-clearcookies.spec.ts:20:3 › should clear cookies
❌ [chromium-library] › library/browsercontext-clearcookies.spec.ts:52:3 › should remove cookies by name
❌ [chromium-library] › library/browsercontext-clearcookies.spec.ts:72:3 › should remove cookies by name regex
❌ [chromium-library] › library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain
❌ [chromium-library] › library/browsercontext-clearcookies.spec.ts:116:3 › should remove cookies by path
❌ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page
❌ [chromium-library] › library/beforeunload.spec.ts:30:3 › should close browsercontext with beforeunload page
❌ [chromium-library] › library/beforeunload.spec.ts:38:3 › should be able to navigate away from page with beforeunload
❌ [chromium-library] › library/beforeunload.spec.ts:46:3 › should close page with beforeunload listener
❌ [chromium-library] › library/beforeunload.spec.ts:55:3 › should run beforeunload if asked for @smoke
❌ [chromium-library] › library/beforeunload.spec.ts:79:3 › should access page after beforeunload
❌ [chromium-library] › library/beforeunload.spec.ts:92:3 › should not stall on evaluate when dismissing beforeunload
❌ [chromium-library] › library/browser.spec.ts:24:5 › should create new page @smoke
❌ [chromium-library] › library/browser.spec.ts:38:5 › should throw upon second create new page
❌ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:22:3 › should work @smoke
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:32:3 › should work with expires=-1
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:50:3 › should add cookies with empty value
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:68:3 › should roundtrip cookie
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:87:3 › should send cookie header
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:99:3 › should isolate cookies in browser contexts
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:115:3 › should isolate session cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:141:3 › should isolate persistent cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:161:3 › should isolate send cookie header
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:182:15 › should isolate cookies between launches
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:197:3 › should set multiple cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:217:3 › should have |expires| set to |-1| for session cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:227:3 › should set cookie with reasonable defaults
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:246:3 › should set a cookie with a path
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:297:3 › should default to setting secure cookie for HTTPS websites
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:309:3 › should be able to set unsecure cookie for HTTP website
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:321:3 › should set a cookie on a different domain
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:342:3 › should set cookies for a frame
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:360:3 › should(not) block third party cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:392:3 › should not block third party SameSite=None cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:429:3 › should allow unnamed cookies
❌ [chromium-library] › library/browsercontext-add-init-script.spec.ts:20:3 › should work with browser context scripts @smoke
❌ [chromium-library] › library/browsercontext-add-init-script.spec.ts:45:3 › should work without navigation in popup
❌ [chromium-library] › library/browsercontext-add-init-script.spec.ts:55:3 › should work with browser context scripts with a path
❌ [chromium-library] › library/browsercontext-add-init-script.spec.ts:62:3 › should work with browser context scripts for already created pages
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:20:3 › should construct a new URL when a baseURL in browser.newContext is passed to page.goto @smoke
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:29:3 › should construct a new URL when a baseURL in browser.newPage is passed to page.goto
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:47:3 › should construct the URLs correctly when a baseURL without a trailing slash in browser.newPage is passed to page.goto
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:57:3 › should construct the URLs correctly when a baseURL with a trailing slash in browser.newPage is passed to page.goto
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:69:3 › should not construct a new URL when valid URLs are passed
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:83:3 › should be able to match a URL relative to its given URL with urlMatcher
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:105:3 › should not construct a new URL with baseURL when a glob was used
❌ [chromium-library] › library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts
❌ [chromium-library] › library/browsercontext-basic.spec.ts:70:3 › window.open should use parent tab context
❌ [chromium-library] › library/browsercontext-basic.spec.ts:82:3 › should isolate localStorage and cookies @smoke
❌ [chromium-library] › library/browsercontext-basic.spec.ts:127:3 › should propagate default viewport to the page
❌ [chromium-library] › library/browsercontext-basic.spec.ts:134:3 › should make a copy of default viewport
❌ [chromium-library] › library/browsercontext-basic.spec.ts:143:3 › should respect deviceScaleFactor
❌ [chromium-library] › library/browsercontext-basic.spec.ts:188:3 › should not report frameless pages on error
❌ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page
❌ [chromium-library] › library/beforeunload.spec.ts:30:3 › should close browsercontext with beforeunload page
❌ [chromium-library] › library/beforeunload.spec.ts:38:3 › should be able to navigate away from page with beforeunload
❌ [chromium-library] › library/beforeunload.spec.ts:46:3 › should close page with beforeunload listener
❌ [chromium-library] › library/beforeunload.spec.ts:55:3 › should run beforeunload if asked for @smoke
❌ [chromium-library] › library/beforeunload.spec.ts:79:3 › should access page after beforeunload
❌ [chromium-library] › library/beforeunload.spec.ts:92:3 › should not stall on evaluate when dismissing beforeunload
❌ [chromium-library] › library/browser.spec.ts:24:5 › should create new page @smoke
❌ [chromium-library] › library/browser.spec.ts:38:5 › should throw upon second create new page
❌ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:22:3 › should work @smoke
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:32:3 › should work with expires=-1
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:50:3 › should add cookies with empty value
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:68:3 › should roundtrip cookie
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:87:3 › should send cookie header
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:115:3 › should isolate session cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:141:3 › should isolate persistent cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:161:3 › should isolate send cookie header
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:197:3 › should set multiple cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:246:3 › should set a cookie with a path
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:297:3 › should default to setting secure cookie for HTTPS websites
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:309:3 › should be able to set unsecure cookie for HTTP website
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:321:3 › should set a cookie on a different domain
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:342:3 › should set cookies for a frame
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:360:3 › should(not) block third party cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:392:3 › should not block third party SameSite=None cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:429:3 › should allow unnamed cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:458:3 › should set secure cookies on secure WebSocket
❌ [chromium-library] › library/browsercontext-add-init-script.spec.ts:20:3 › should work with browser context scripts @smoke
❌ [chromium-library] › library/browsercontext-add-init-script.spec.ts:28:3 › should work without navigation, after all bindings
❌ [chromium-library] › library/browsercontext-add-init-script.spec.ts:45:3 › should work without navigation in popup
❌ [chromium-library] › library/browsercontext-add-init-script.spec.ts:55:3 › should work with browser context scripts with a path
❌ [chromium-library] › library/browsercontext-add-init-script.spec.ts:62:3 › should work with browser context scripts for already created pages
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:20:3 › should construct a new URL when a baseURL in browser.newContext is passed to page.goto @smoke
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:29:3 › should construct a new URL when a baseURL in browser.newPage is passed to page.goto
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:47:3 › should construct the URLs correctly when a baseURL without a trailing slash in browser.newPage is passed to page.goto
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:57:3 › should construct the URLs correctly when a baseURL with a trailing slash in browser.newPage is passed to page.goto
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:69:3 › should not construct a new URL when valid URLs are passed
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:83:3 › should be able to match a URL relative to its given URL with urlMatcher
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:105:3 › should not construct a new URL with baseURL when a glob was used
❌ [chromium-library] › library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts
❌ [chromium-library] › library/browsercontext-basic.spec.ts:70:3 › window.open should use parent tab context
❌ [chromium-library] › library/browsercontext-basic.spec.ts:82:3 › should isolate localStorage and cookies @smoke
❌ [chromium-library] › library/browsercontext-basic.spec.ts:127:3 › should propagate default viewport to the page
❌ [chromium-library] › library/browsercontext-basic.spec.ts:134:3 › should make a copy of default viewport
❌ [chromium-library] › library/browsercontext-clearcookies.spec.ts:20:3 › should clear cookies
❌ [chromium-library] › library/browsercontext-clearcookies.spec.ts:52:3 › should remove cookies by name
❌ [chromium-library] › library/browsercontext-clearcookies.spec.ts:72:3 › should remove cookies by name regex
❌ [chromium-library] › library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain
❌ [chromium-library] › library/browsercontext-clearcookies.spec.ts:116:3 › should remove cookies by path
❌ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page
❌ [chromium-library] › library/beforeunload.spec.ts:30:3 › should close browsercontext with beforeunload page
❌ [chromium-library] › library/beforeunload.spec.ts:38:3 › should be able to navigate away from page with beforeunload
❌ [chromium-library] › library/beforeunload.spec.ts:46:3 › should close page with beforeunload listener
❌ [chromium-library] › library/beforeunload.spec.ts:55:3 › should run beforeunload if asked for @smoke
❌ [chromium-library] › library/beforeunload.spec.ts:79:3 › should access page after beforeunload
❌ [chromium-library] › library/beforeunload.spec.ts:92:3 › should not stall on evaluate when dismissing beforeunload
❌ [chromium-library] › library/browser.spec.ts:24:5 › should create new page @smoke
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:22:3 › should work @smoke
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:32:3 › should work with expires=-1
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:50:3 › should add cookies with empty value
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:68:3 › should roundtrip cookie
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:87:3 › should send cookie header
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:99:3 › should isolate cookies in browser contexts
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:115:3 › should isolate session cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:141:3 › should isolate persistent cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:161:3 › should isolate send cookie header
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:182:15 › should isolate cookies between launches
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:197:3 › should set multiple cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:217:3 › should have |expires| set to |-1| for session cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:227:3 › should set cookie with reasonable defaults
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:246:3 › should set a cookie with a path
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:297:3 › should default to setting secure cookie for HTTPS websites
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:309:3 › should be able to set unsecure cookie for HTTP website
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:321:3 › should set a cookie on a different domain
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:342:3 › should set cookies for a frame
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:360:3 › should(not) block third party cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:392:3 › should not block third party SameSite=None cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:429:3 › should allow unnamed cookies
❌ [chromium-library] › library/browsercontext-add-cookies.spec.ts:458:3 › should set secure cookies on secure WebSocket
❌ [chromium-library] › library/browsercontext-add-init-script.spec.ts:20:3 › should work with browser context scripts @smoke
❌ [chromium-library] › library/browsercontext-add-init-script.spec.ts:28:3 › should work without navigation, after all bindings
❌ [chromium-library] › library/browsercontext-add-init-script.spec.ts:45:3 › should work without navigation in popup
❌ [chromium-library] › library/browsercontext-add-init-script.spec.ts:55:3 › should work with browser context scripts with a path
❌ [chromium-library] › library/browsercontext-add-init-script.spec.ts:62:3 › should work with browser context scripts for already created pages
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:20:3 › should construct a new URL when a baseURL in browser.newContext is passed to page.goto @smoke
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:29:3 › should construct a new URL when a baseURL in browser.newPage is passed to page.goto
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:47:3 › should construct the URLs correctly when a baseURL without a trailing slash in browser.newPage is passed to page.goto
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:57:3 › should construct the URLs correctly when a baseURL with a trailing slash in browser.newPage is passed to page.goto
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:69:3 › should not construct a new URL when valid URLs are passed
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:83:3 › should be able to match a URL relative to its given URL with urlMatcher
❌ [chromium-library] › library/browsercontext-base-url.spec.ts:105:3 › should not construct a new URL with baseURL when a glob was used
❌ [chromium-library] › library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts
❌ [chromium-library] › library/browsercontext-basic.spec.ts:70:3 › window.open should use parent tab context
❌ [chromium-library] › library/browsercontext-basic.spec.ts:82:3 › should isolate localStorage and cookies @smoke
❌ [chromium-library] › library/browsercontext-basic.spec.ts:127:3 › should propagate default viewport to the page
❌ [chromium-library] › library/browsercontext-basic.spec.ts:143:3 › should respect deviceScaleFactor
❌ [chromium-library] › library/browsercontext-basic.spec.ts:188:3 › should not report frameless pages on error
❌ [chromium-library] › library/browsercontext-clearcookies.spec.ts:20:3 › should clear cookies
❌ [webkit-page] › page/page-wait-for-navigation.spec.ts:85:3 › should work with clicking on links which do not commit navigation

53 flaky ⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:23:7 › cli codegen › should click
⚠️ [chromium-library] › library/emulation-focus.spec.ts:202:12 › should trigger hover state concurrently
⚠️ [chromium-library] › library/tap.spec.ts:23:3 › should send all of the correct events @smoke
⚠️ [chromium-library] › library/video.spec.ts:351:5 › screencast › should capture navigation
⚠️ [chromium-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [chromium-page] › page/page-mouse.spec.ts:186:3 › should trigger hover state on disabled button
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:258:7 › cli codegen › should fill japanese text
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:791:7 › cli codegen › should click button with nested div
⚠️ [chromium-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [chromium-page] › page/page-click.spec.ts:230:3 › should click on checkbox input and toggle
⚠️ [chromium-library] › library/selector-generator.spec.ts:40:5 › selector generator › should prefer role=button over inner span
⚠️ [chromium-library] › library/video.spec.ts:351:5 › screencast › should capture navigation
⚠️ [chromium-page] › page/page-event-request.spec.ts:110:3 › should report navigation requests and responses handled by service worker
⚠️ [chromium-page] › page/page-event-request.spec.ts:139:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [firefox-library] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [firefox-page] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [firefox-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [firefox-library] › library/video.spec.ts:730:5 › screencast › should capture full viewport on hidpi
⚠️ [firefox-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [firefox-page] › page/page-click.spec.ts:848:3 › should not hang when frame is detached
⚠️ [firefox-library] › library/hit-target.spec.ts:244:3 › should not click iframe overlaying the target
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:551:5 › should --test-id-attribute
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:22:7 › cli codegen › should click locator.first
⚠️ [firefox-library] › library/tracing.spec.ts:292:5 › should overwrite existing file
⚠️ [firefox-library] › library/video.spec.ts:227:5 › screencast › saveAs should throw when no video frames
⚠️ [firefox-page] › page/page-click.spec.ts:97:3 › should click the 1x1 div
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:381:5 › launchServer › should emit close events on pages and contexts
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work
⚠️ [chromium-library] › library/browsertype-launch.spec.ts:124:3 › should be callable twice
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:43:5 › should use logger in default context
⚠️ [chromium-library] › library/chromium/launcher.spec.ts:28:3 › should not throw with remote-debugging-port argument
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:493:7 › cli codegen › should --save-trace
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:791:7 › cli codegen › should click button with nested div
⚠️ [chromium-library] › library/trace-viewer.spec.ts:171:1 › should open console errors on click
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate
⚠️ [chromium-library] › library/browsercontext-add-init-script.spec.ts:28:3 › should work without navigation, after all bindings
⚠️ [chromium-library] › library/browser.spec.ts:38:5 › should throw upon second create new page
⚠️ [chromium-library] › library/browsercontext-basic.spec.ts:134:3 › should make a copy of default viewport
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:56:7 › cli codegen › should ignore programmatic events
⚠️ [webkit-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [webkit-library] › library/emulation-focus.spec.ts:202:12 › should trigger hover state concurrently
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit-library] › library/browsercontext-viewport.spec.ts:145:12 › should drag with high dpi
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:415:7 › cli codegen › should generate getByPlaceholder
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:444:7 › cli codegen › should generate getByAltText
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:562:7 › cli codegen › should assert value
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:634:7 › cli codegen › should assert visibility
⚠️ [webkit-page] › page/elementhandle-misc.spec.ts:27:3 › should hover when Node is removed
⚠️ [webkit-page] › page/page-goto.spec.ts:277:3 › should fail when navigating to bad SSL after redirects
⚠️ [webkit-page] › page/workers.spec.ts:243:3 › should support offline
2 interrupted ⚠️ [chromium-library] › library/browsercontext-basic.spec.ts:143:3 › should respect deviceScaleFactor
⚠️ [chromium-library] › library/browsercontext-add-cookies.spec.ts:458:3 › should set secure cookies on secure WebSocket

191462 passed, 8695 skipped, 15988 did not run
✔️✔️✔️

Merge workflow run.

@dgozman
Copy link
Contributor

dgozman commented Jun 21, 2024

The upstream issue is fixed, so hopefully r1234 will be good.

@mxschmitt mxschmitt deleted the roll-into-pw-chromium-tip-of-tree/1232 branch July 27, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants