-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chromium-tip-of-tree): roll to r1232 #31362
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Max Schmitt <[email protected]>
Test results for "tests 1"1 fatal errors, not part of any test 3 flaky1 interrupted24722 passed, 568 skipped, 3648 did not run Merge workflow run. |
Test results for "tests others"2 failed 2 flaky17637 passed, 589 skipped Merge workflow run. |
Test results for "tests 2"8 fatal errors, not part of any test 53 flaky2 interrupted191462 passed, 8695 skipped, 15988 did not run Merge workflow run. |
The upstream issue is fixed, so hopefully r1234 will be good. |
Good:
Bad:
Failing PR: #31362
Failing tests:
Bisect 1 (
library/browsercontext-credentials.spec.ts:27:1
):Command:
npx bisect-chrome --good 1314318 --bad 1316206 --shell "npm run ctest -- --reporter=list library/browsercontext-credentials.spec.ts:27:1"
RANGE: https://chromium.googlesource.com/chromium/src/+log/fadb61567ce2a7f1bcc181ce65e000d56064fe8d..1f24a69d69b03bc83a26bed4c236e397d6ba44c2
Commit: https://chromium.googlesource.com/chromium/src/+/b9b39a430f71c710d16aafcc67278ef77440c18d
Resolution: --headless -> --headless=old
This causes crashes with:
Minimal repro is:
Filed as https://issues.chromium.org/u/1/issues/348031037