Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: properly initialize Touch arguments in TouchEvent #34200

Merged
merged 4 commits into from
Jan 3, 2025

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Jan 3, 2025

No description provided.

@yury-s yury-s requested a review from dgozman January 3, 2025 00:25

This comment has been minimized.

tests/page/page-dispatchevent.spec.ts Outdated Show resolved Hide resolved
Copy link
Member Author

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out Touch can't be constructed in JavaScript in Safari.

Copy link
Member Author

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out Touch can't be constructed in JavaScript in Safari.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Test results for "tests 1"

4 failed
❌ [playwright-test] › reporter.spec.ts:297:9 › merged › should report no-tests error to reporter @macos-latest-node18-1
❌ [installation tests] › playwright-electron-should-work.spec.ts:21:5 › electron should work @package-installations-ubuntu-latest
❌ [installation tests] › playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path @package-installations-ubuntu-latest
❌ [installation tests] › playwright-electron-should-work.spec.ts:44:5 › should work when wrapped inside @playwright/test and trace is enabled @package-installations-ubuntu-latest

7 flaky ⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-setup.spec.ts:98:5 › should show errors in config @macos-latest-node18-1
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:330:5 › launchServer › should throw when used after isConnected returns false @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsertype-launch.spec.ts:22:3 › should reject all promises when browser is closed @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/selector-generator.spec.ts:64:5 › selector generator › should generate text for @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:147:3 › should upload large file @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37511 passed, 654 skipped
✔️✔️✔️

Merge workflow run.

@yury-s yury-s merged commit 8b45ea6 into microsoft:main Jan 3, 2025
27 of 29 checks passed
@yury-s yury-s deleted the dispatch-touch branch January 3, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants