Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prepare CI to properly run Electron on ubuntu-latest (24.04) #34238

Merged
merged 15 commits into from
Jan 9, 2025
Merged

fix: Prepare CI to properly run Electron on ubuntu-latest (24.04) #34238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
68c7499
fix: Prepare CI to properly run Electron on ubuntu-latest (24.04)
agg23 Jan 7, 2025
5ad5d1a
Try built-in Playwright Chromium deps installation for Ubuntu
agg23 Jan 7, 2025
ae8cdd7
Add debugging information
agg23 Jan 7, 2025
9e5cb11
SSH test
agg23 Jan 7, 2025
58e6d5a
Add AppArmor fix
agg23 Jan 7, 2025
9b269e8
Try without apt install
agg23 Jan 7, 2025
1a7ec58
Remove other apt install
agg23 Jan 7, 2025
b210a11
Centralize Ubuntu Electron fix
agg23 Jan 8, 2025
c7655eb
Try adding shell specification
agg23 Jan 8, 2025
d27cd84
Move before npm ci
agg23 Jan 8, 2025
f44017c
Only run AppArmor command if Ubuntu 24
agg23 Jan 8, 2025
49d2f3a
Fix VSCode extension
agg23 Jan 8, 2025
6c49741
Remove change to VSCode extension
agg23 Jan 8, 2025
4c9a01b
Make Electron fix selective to Electron tests
agg23 Jan 8, 2025
013e5ec
Add missed installation test fix
agg23 Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/tests_others.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,13 @@ jobs:
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
- name: Setup Ubuntu Binary Installation # TODO: Remove when https://github.com/electron/electron/issues/42510 is fixed
if: ${{ runner.os == 'Linux' }}
run: |
if grep -q "Ubuntu 24" /etc/os-release; then
sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0
fi
shell: bash
- uses: ./.github/actions/run-test
with:
browsers-to-install: chromium
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/tests_primary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,13 @@ jobs:
- uses: actions/checkout@v4
- run: npm install -g yarn@1
- run: npm install -g pnpm@8
- name: Setup Ubuntu Binary Installation # TODO: Remove when https://github.com/electron/electron/issues/42510 is fixed
if: ${{ runner.os == 'Linux' }}
run: |
if grep -q "Ubuntu 24" /etc/os-release; then
sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0
fi
shell: bash
- uses: ./.github/actions/run-test
with:
command: npm run itest
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/tests_secondary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,13 @@ jobs:
- uses: actions/checkout@v4
- run: npm install -g yarn@1
- run: npm install -g pnpm@8
- name: Setup Ubuntu Binary Installation # TODO: Remove when https://github.com/electron/electron/issues/42510 is fixed
if: ${{ runner.os == 'Linux' }}
run: |
if grep -q "Ubuntu 24" /etc/os-release; then
sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0
Copy link
Member

@yury-s yury-s Jan 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this actually help? We already run electron with --no-sandbox which is recommended as alternative solution in the internet. In github codespaces changing this option didn't have any effect on the tests for me.

Update: it did help in the codespaces, but not in 24.04 docker.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that it's relevant here, but what error were you seeing in Docker? If it's not the same image as the CI machines there may be additional dependencies that need to be installed.

fi
shell: bash
- uses: ./.github/actions/run-test
with:
node-version: ${{ matrix.node_version }}
Expand Down
Loading