Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move github init after app target setup #10284

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

riknoll
Copy link
Member

@riknoll riknoll commented Nov 20, 2024

noticed this exception in the console; initGithubDb is called before the app target is being set which was throwing an exception. the exception happens in an async context so it wasn't actually causing any errors but it does prevent the indexeddb from purging expired entries

@riknoll riknoll requested a review from a team November 20, 2024 22:56
@abchatra
Copy link
Collaborator

@riknoll does this need to be ported for Minecraft?

@riknoll riknoll merged commit 327ab19 into master Jan 17, 2025
7 checks passed
@riknoll riknoll deleted the dev/riknoll/move-github-init branch January 17, 2025 18:03
riknoll added a commit that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants