Update tilemap/image/animation editor to use react common components #10317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Joey Wunderlich <[email protected]>
|
5 page limit? Is that normal |
|
@Nolan0027 it's not an actual limit, it's just the max number of dots that will be displayed. you can still use the arrows to move further forward/back in the list |
|
@riknoll ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes microsoft/pxt-arcade#5924
this replaces all of the custom buttons and dropdowns that we have in the tilemap/image/animation editors with the buttons from react-common, which are better for accessibility.
also re-implements the tilemap palette page selector so that it now has a maximum of 5 pages
also adds a "FocusTrapRegion" subcomponent that lets you turn tab navigation on/off for regions within a focus trap. you can also use it to control the order of tab navigation when it differs from what's actually in the dom