Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: introduction of preview mode #185

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

DariuszPorowski
Copy link
Member

📥 Pull Request

❓ What are you trying to address

This pull request includes several changes to the documentation and configuration to introduce a preview mode for various resources and data sources. The changes ensure that users are aware of the risks associated with using preview features and require explicit opt-in at the provider level configuration.

Copy link

github-actions bot commented Jan 8, 2025

Changelog Preview

v0.1.0-dev - January 09, 2025

💥 Breaking

  • #185 Using preview resources or data sources now needs explicit opt-in at the provider level configuration by setting the preview attribute to true.
    This is to ensure that users are aware of the risks of using preview resources or data sources in production environments.
    Usage of any preview feature will result in a warning message in the Terraform output.

✨ Added

  • #135 Definition support in the fabric_eventhouse Resource
  • #156 Definition support in the fabric_eventhouse Data-Sources

Copy link

github-actions bot commented Jan 8, 2025

Code Coverage

Package Line Rate Complexity Health
github.com/microsoft/terraform-provider-fabric/internal/auth 74% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/customtypes 75% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/planmodifiers 62% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/typeutils 63% 0
github.com/microsoft/terraform-provider-fabric/internal/functions 72% 0
github.com/microsoft/terraform-provider-fabric/internal/pkg/fabricitem 71% 0
github.com/microsoft/terraform-provider-fabric/internal/pkg/transforms 62% 0
github.com/microsoft/terraform-provider-fabric/internal/pkg/utils 84% 0
github.com/microsoft/terraform-provider-fabric/internal/provider 87% 0
github.com/microsoft/terraform-provider-fabric/internal/provider/config 100% 0
github.com/microsoft/terraform-provider-fabric/internal/provider/utils 69% 0
github.com/microsoft/terraform-provider-fabric/internal/services/capacity 87% 0
github.com/microsoft/terraform-provider-fabric/internal/services/dashboard 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/datamart 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/datapipeline 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/domain 42% 0
github.com/microsoft/terraform-provider-fabric/internal/services/environment 87% 0
github.com/microsoft/terraform-provider-fabric/internal/services/eventhouse 92% 0
github.com/microsoft/terraform-provider-fabric/internal/services/eventstream 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/kqldatabase 82% 0
github.com/microsoft/terraform-provider-fabric/internal/services/kqlqueryset 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/lakehouse 86% 0
github.com/microsoft/terraform-provider-fabric/internal/services/mirroredwarehouse 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/mlexperiment 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/mlmodel 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/notebook 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/paginatedreport 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/report 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/semanticmodel 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/spark 74% 0
github.com/microsoft/terraform-provider-fabric/internal/services/sparkjobdefinition 92% 0
github.com/microsoft/terraform-provider-fabric/internal/services/sqlendpoint 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/warehouse 92% 0
github.com/microsoft/terraform-provider-fabric/internal/services/workspace 78% 0
Summary 72% (3896 / 5377) 0

Minimum allowed line rate is 40%

@DariuszPorowski DariuszPorowski marked this pull request as ready for review January 8, 2025 08:13
@DariuszPorowski DariuszPorowski requested a review from a team as a code owner January 8, 2025 08:13
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 61.27563% with 170 lines in your changes missing coverage. Please review.

Project coverage is 75.97%. Comparing base (5578a67) to head (d4e80a8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...item/resource_item_config_definition_properties.go 0.00% 15 Missing ⚠️
...ervices/domain/resource_domain_role_assignments.go 46.42% 15 Missing ⚠️
internal/pkg/fabricitem/data_item_definition.go 20.00% 12 Missing ⚠️
.../pkg/fabricitem/data_item_definition_properties.go 20.00% 12 Missing ⚠️
.../pkg/fabricitem/resource_item_config_properties.go 20.00% 12 Missing ⚠️
.../fabricitem/resource_item_definition_properties.go 20.00% 12 Missing ⚠️
internal/pkg/fabricitem/data_item.go 53.33% 7 Missing ⚠️
internal/pkg/fabricitem/data_item_properties.go 53.33% 7 Missing ⚠️
internal/pkg/fabricitem/data_items.go 53.33% 7 Missing ⚠️
internal/pkg/fabricitem/data_items_properties.go 53.33% 7 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
- Coverage   76.58%   75.97%   -0.62%     
==========================================
  Files         148      148              
  Lines       12631    13012     +381     
==========================================
+ Hits         9674     9886     +212     
- Misses       2952     3121     +169     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants