-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Update dependencies from dotnet/arcade #4258
[main] Update dependencies from dotnet/arcade #4258
Conversation
…205.6 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.XliffTasks From Version 10.0.0-beta.24604.4 -> To Version 10.0.0-beta.24605.6
…ild 20241205.2 Microsoft.Testing.Extensions.Retry From Version 1.5.0-preview.24604.2 -> To Version 1.5.0-preview.24605.2
…206.6 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.XliffTasks From Version 10.0.0-beta.24604.4 -> To Version 10.0.0-beta.24606.6
…ild 20241206.1 Microsoft.Testing.Extensions.Retry From Version 1.5.0-preview.24604.2 -> To Version 1.5.0-preview.24606.1
…code-coverage build 20241206.2 Microsoft.Testing.Extensions.CodeCoverage From Version 17.13.2-preview.24605.2 -> To Version 17.13.2-preview.24606.2
…ild 20241207.2 Microsoft.Testing.Extensions.Retry From Version 1.5.0-preview.24604.2 -> To Version 1.5.0-preview.24607.2
…ild 20241208.1 Microsoft.Testing.Extensions.Retry From Version 1.5.0-preview.24604.2 -> To Version 1.5.0-preview.24608.1
…ild 20241211.2 Microsoft.Testing.Extensions.Retry From Version 1.5.0-preview.24608.1 -> To Version 1.5.0-preview.24611.2
# Conflicts: # eng/Version.Details.xml # eng/Versions.props
…ild 20241211.3 Microsoft.Testing.Extensions.Retry From Version 1.5.0-preview.24608.1 -> To Version 1.5.0-preview.24611.3
…ild 20241213.1 Microsoft.Testing.Extensions.Retry From Version 1.5.0-preview.24608.1 -> To Version 1.5.0-preview.24613.1
…ild 20241214.1 Microsoft.Testing.Extensions.Retry From Version 1.5.0-preview.24608.1 -> To Version 1.5.0-preview.24614.1
…ild 20241216.3 Microsoft.Testing.Extensions.Retry From Version 1.5.0-preview.24608.1 -> To Version 1.6.0-preview.24616.3
…code-coverage build 20241216.1 Microsoft.Testing.Extensions.CodeCoverage From Version 17.13.2-preview.24606.2 -> To Version 17.14.0-preview.24616.1
…ild 20241216.4 Microsoft.Testing.Extensions.Retry From Version 1.5.0-preview.24608.1 -> To Version 1.6.0-preview.24616.4
…ild 20241217.4 Microsoft.Testing.Extensions.Retry From Version 1.5.0-preview.24608.1 -> To Version 1.6.0-preview.24617.4
We need to investigate the |
@Evangelink It looks like the last build in this PR doesn't have the System.Runtime.CompilerServices.Unsafe issue? Not sure what have changed to let that failure go away. I haven't re-tested locally again yet. There is now failure that happens only in SB though
But that doesn't seem to be something on our side? dotnet/source-build#4810 |
@@ -1,6 +1,6 @@ | |||
{ | |||
"tools": { | |||
"dotnet": "9.0.100", | |||
"dotnet": "10.0.100-alpha.1.24573.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Evangelink Do we want to move that fast to 10.x?
I'd also assume that downgrading back to 9.0.100 will be green and avoid the current SB issue until it's investigated further.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to stay on a 9.0.100 SDK then you should change your Arcade subscription channel to ".NET 9 Eng". That said, building with a newer .NET SDK and Arcade SDK dogfoods the product and provides with valuable data. Most of our repositories build with Arcade 10 and .NET 10 SDK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only concern is that in past some community member were complaining we were on 9 and it was impacting their ability to contribute. But let's try 10 and see how community reacts.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4258 +/- ##
==========================================
+ Coverage 64.10% 64.17% +0.06%
==========================================
Files 591 591
Lines 35090 35090
==========================================
+ Hits 22496 22520 +24
+ Misses 12594 12570 -24
Flags with carried forward coverage won't be shown. Click here to find out more. |
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
From https://github.com/microsoft/testanywhere
From https://dev.azure.com/devdiv/DevDiv/_git/vs-code-coverage