simplify some dictionary usage #4575
Open
+4
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonCropp
requested review from
MarcoRossignoli and
Evangelink
as code owners
Youssef1313
reviewed
Jan 9, 2025
Youssef1313
reviewed
Jan 9, 2025
| @@ -84,7 +84,7 @@ public MethodInfo[] GetRuntimeMethods(Type type) | |||
| Dictionary<string, PropertyInfo> type = ReflectionDataProvider.TypePropertiesByName[classType]; | |||
|
|
|||
| // We as asking for TestContext here, it may not be there. | |||
| PropertyInfo? property = type.TryGetValue(propertyName, out PropertyInfo? propertyInfo) ? propertyInfo : null; | |||
| PropertyInfo? property = type.GetValueOrDefault(propertyName); | |||
There was a problem hiding this comment.
Suggested change
| PropertyInfo? property = type.GetValueOrDefault(propertyName); | |
| _ = type.TryGetValue(propertyName, PropertyInfo? property); |
There was a problem hiding this comment.
why not GetValueOrDefault ?
There was a problem hiding this comment.
They are the same, nothing really wrong about GetValueOrDefault.
GetValueOrDefault will end up calling TryGetValue at the end of the day, so I preferred to call TryGetValue directly unless GetValueOrDefault is saving annoying conditional syntax (like the case in GetMetadata below in the PR)
It's mostly personal opinion/style though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.