-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade deprecated azure tools package #372
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackchoey
requested review from
Copilot,
annaji-msft,
malincrist and
adashen
and removed request for
annaji-msft
January 6, 2025 07:46
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 96 out of 111 changed files in this pull request and generated 1 comment.
Files not reviewed (15)
- package.json: Language not supported
- src/commands/authorizations/common.ts: Evaluated as low risk
- src/commands/authorizations/createAuthorizationAccessPolicy.ts: Evaluated as low risk
- src/commands/addApiFilter.ts: Evaluated as low risk
- src/azure/webApp/FunctionAppService.ts: Evaluated as low risk
- src/commands/authorizations/createAuthorization.ts: Evaluated as low risk
- src/commands/authorizations/authorizeAuthorization.ts: Evaluated as low risk
- src/azure/resourceGraph/ResourceGraphService.ts: Evaluated as low risk
- src/azure/apim/ApimService.ts: Evaluated as low risk
- src/commands/authorizations/createAuthorizationProvider.ts: Evaluated as low risk
- src/commands/addApiToProduct.ts: Evaluated as low risk
- src/commands/addApiToGateway.ts: Evaluated as low risk
- src/commands/authorizations/copyAuthorizationProviderRedirectUrl.ts: Evaluated as low risk
- src/commands/authorizations/copyAuthorizationPolicy.ts: Evaluated as low risk
- src/azure/graph/GraphService.ts: Evaluated as low risk
malincrist
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting up new CI pipelines, I found the pipeline cannot success anymore due to the deprecated
vscode
package. Update below packages to ensure we can continue setup the pipelines.vscode
package to@types/vscode
and@vscode/test-electron
.vscode-azureextensionui
package to@microsoft/vscode-azext-azureutils
and@microsoft/vscode-azext-utils
.vscode-azureextensiondev
package to@microsoft/vscode-azext-dev
.After upgraded above packages, following changes were made to pass the build:
7. Initialize
ServiceClient
directly instead of usingcreateGenericClient
as the type of provided credential cannot be used bycreateGenericClient
directly. Appendvscode-apimanagement
user agent to the service client when initializing.8. Use the
ui
element inIActionContext
instead ofext.ui
from extension variables to control VS Code UI. This is because theAzureUserInput
class is no longer exported by the@microsoft/vscode-azext-utils
package, so we cannot initializeext.ui
proactively anymore.9. Since
AzExtTreeItem
and other tree items no longer has theroot
property that saves information about the resource, addITreeItemWithRoot
interface to add theroot
property back in order to reduce code change during the upgrade.10. Add additional
root
parameter in each TreeItem's constructor to initialize and expose theroot
property.11. Update editor classes to leverage
ITreeItemWithRoot
instead of using theroot
property in oldAzureParentTreeItem
.12. Update some TreeItem implementation due to the interface change in
AzExtTreeItem
. For example: changecommandId
from a property to an accessor.13. Update Azure SDK related logic to support the Track 2 SDK. The paging implementation is removed temporary to reduce the effort of the upgrade as the implementation is totally different. Will add paging back in another PR.
14. Use
@vscode/test-cli
to run test casesFollow ups (will create other PR):
How to set the
body
's value inConsoleRequest.ts
Add paging back when show resources in tree view, right now we show all the resource