Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dotnet version check always fail #382

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

blackchoey
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/utils/dotnetUtils.ts:2

  • Using parseInt in map can lead to incorrect parsing of version numbers. Use Number instead.
const v1 = version1.split('.').map(parseInt);

src/utils/dotnetUtils.ts:3

  • Using parseInt in map can lead to incorrect parsing of version numbers. Use Number instead.
const v2 = version2.split('.').map(parseInt);
@blackchoey blackchoey merged commit 5914868 into main Jan 20, 2025
2 checks passed
@blackchoey blackchoey deleted the chyuan/fix-dotnet-check branch January 20, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants