Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip some unrequired checkov checks #7161

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Skip some unrequired checkov checks #7161

merged 1 commit into from
Jun 4, 2024

Conversation

SteveLinden
Copy link
Contributor

A reference to the issue / Description of it

There are a number of checkov errors showing up in the daily static code analysis. This PR is to skip those checks (they are not required) so the errors no longer continue.

We may find additional ones pop up from time to time and these can be dealt with as they are found.

@SteveLinden SteveLinden requested a review from a team as a code owner June 4, 2024 12:52
@github-actions github-actions bot added the core label Jun 4, 2024
Copy link
Contributor

github-actions bot commented Jun 4, 2024

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/environments/core-shared-services terraform/modules/vpc-hub terraform/modules/vpc-inspection


Running Trivy in terraform/environments/core-shared-services
2024-06-04T12:54:19Z INFO Need to update DB
2024-06-04T12:54:19Z INFO Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-06-04T12:54:21Z INFO Vulnerability scanning is enabled
2024-06-04T12:54:21Z INFO Misconfiguration scanning is enabled
2024-06-04T12:54:21Z INFO Need to update the built-in policies
2024-06-04T12:54:21Z INFO Downloading the built-in policies...
49.76 KiB / 49.76 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-06-04T12:54:21Z INFO Secret scanning is enabled
2024-06-04T12:54:21Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-04T12:54:21Z INFO Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-04T12:54:38Z INFO Number of language-specific files num=1
2024-06-04T12:54:38Z INFO [gomod] Detecting vulnerabilities...
2024-06-04T12:54:38Z INFO Detected config files num=8

../../modules/app-ecr-repo/main.tf (terraform)

Tests: 60 (SUCCESSES: 30, FAILURES: 0, EXCEPTIONS: 30)
Failures: 0 (HIGH: 0, CRITICAL: 0)

ad-fixngo.tf (terraform)

Tests: 75 (SUCCESSES: 60, FAILURES: 0, EXCEPTIONS: 15)
Failures: 0 (HIGH: 0, CRITICAL: 0)

iam.tf (terraform)

Tests: 19 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 19)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0


Running Trivy in terraform/modules/vpc-hub
2024-06-04T12:54:39Z INFO Vulnerability scanning is enabled
2024-06-04T12:54:39Z INFO Misconfiguration scanning is enabled
2024-06-04T12:54:39Z INFO Secret scanning is enabled
2024-06-04T12:54:39Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-04T12:54:39Z INFO Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-04T12:54:39Z INFO Number of language-specific files num=0
2024-06-04T12:54:39Z INFO Detected config files num=2
trivy_exitcode=0


Running Trivy in terraform/modules/vpc-inspection
2024-06-04T12:54:39Z INFO Vulnerability scanning is enabled
2024-06-04T12:54:39Z INFO Misconfiguration scanning is enabled
2024-06-04T12:54:39Z INFO Secret scanning is enabled
2024-06-04T12:54:39Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-04T12:54:39Z INFO Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-04T12:54:40Z INFO Number of language-specific files num=0
2024-06-04T12:54:40Z INFO Detected config files num=3
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/core-shared-services terraform/modules/vpc-hub terraform/modules/vpc-inspection

*****************************

Running Checkov in terraform/environments/core-shared-services
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
2024-06-04 12:54:42,931 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-environments//terraform/modules/ip_addresses?ref=29c48e315aa5eeef5d604617169b2f6db953966e:None (for external modules, the --download-external-modules flag is required)
2024-06-04 12:54:42,931 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-ssm-patching.git?ref=v3.0.0:None (for external modules, the --download-external-modules flag is required)
2024-06-04 12:54:42,931 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-github-oidc-provider?ref=82f546bd5f002674138a2ccdade7d7618c6758b3:None (for external modules, the --download-external-modules flag is required)
2024-06-04 12:54:42,931 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-cross-account-access?ref=6819b090bce6d3068d55c7c7b9b3fd18c9dca648:None (for external modules, the --download-external-modules flag is required)
2024-06-04 12:54:42,931 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1:None (for external modules, the --download-external-modules flag is required)
2024-06-04 12:54:42,931 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-lambda-function?ref=5a3c02a071519986a0ae415168fb4f9d3fb7970f:None (for external modules, the --download-external-modules flag is required)
2024-06-04 12:54:42,931 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-pagerduty-integration?ref=0179859e6fafc567843cd55c0b05d325d5012dc4:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 1242, Failed checks: 0, Skipped checks: 263


checkov_exitcode=0

*****************************

Running Checkov in terraform/modules/vpc-hub
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 50, Failed checks: 0, Skipped checks: 17


checkov_exitcode=0

*****************************

Running Checkov in terraform/modules/vpc-inspection
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 53, Failed checks: 0, Skipped checks: 19


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/environments/core-shared-services terraform/modules/vpc-hub terraform/modules/vpc-inspection

*****************************

Running tflint in terraform/environments/core-shared-services
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

*****************************

Running tflint in terraform/modules/vpc-hub
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

*****************************

Running tflint in terraform/modules/vpc-inspection
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:
terraform/environments/core-shared-services terraform/modules/vpc-hub terraform/modules/vpc-inspection

*****************************

Running Trivy in terraform/environments/core-shared-services
2024-06-04T12:54:19Z	INFO	Need to update DB
2024-06-04T12:54:19Z	INFO	Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-06-04T12:54:21Z	INFO	Vulnerability scanning is enabled
2024-06-04T12:54:21Z	INFO	Misconfiguration scanning is enabled
2024-06-04T12:54:21Z	INFO	Need to update the built-in policies
2024-06-04T12:54:21Z	INFO	Downloading the built-in policies...
49.76 KiB / 49.76 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-06-04T12:54:21Z	INFO	Secret scanning is enabled
2024-06-04T12:54:21Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-04T12:54:21Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-04T12:54:38Z	INFO	Number of language-specific files	num=1
2024-06-04T12:54:38Z	INFO	[gomod] Detecting vulnerabilities...
2024-06-04T12:54:38Z	INFO	Detected config files	num=8

../../modules/app-ecr-repo/main.tf (terraform)
==============================================
Tests: 60 (SUCCESSES: 30, FAILURES: 0, EXCEPTIONS: 30)
Failures: 0 (HIGH: 0, CRITICAL: 0)


ad-fixngo.tf (terraform)
========================
Tests: 75 (SUCCESSES: 60, FAILURES: 0, EXCEPTIONS: 15)
Failures: 0 (HIGH: 0, CRITICAL: 0)


iam.tf (terraform)
==================
Tests: 19 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 19)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

*****************************

Running Trivy in terraform/modules/vpc-hub
2024-06-04T12:54:39Z	INFO	Vulnerability scanning is enabled
2024-06-04T12:54:39Z	INFO	Misconfiguration scanning is enabled
2024-06-04T12:54:39Z	INFO	Secret scanning is enabled
2024-06-04T12:54:39Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-04T12:54:39Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-04T12:54:39Z	INFO	Number of language-specific files	num=0
2024-06-04T12:54:39Z	INFO	Detected config files	num=2
trivy_exitcode=0

*****************************

Running Trivy in terraform/modules/vpc-inspection
2024-06-04T12:54:39Z	INFO	Vulnerability scanning is enabled
2024-06-04T12:54:39Z	INFO	Misconfiguration scanning is enabled
2024-06-04T12:54:39Z	INFO	Secret scanning is enabled
2024-06-04T12:54:39Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-04T12:54:39Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-04T12:54:40Z	INFO	Number of language-specific files	num=0
2024-06-04T12:54:40Z	INFO	Detected config files	num=3
trivy_exitcode=0

@dms1981 dms1981 added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit c55a8d0 Jun 4, 2024
13 checks passed
@dms1981 dms1981 deleted the bugfix/checkov-errors branch June 4, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants