Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed references to the S3 replication role module #7176

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Removed references to the S3 replication role module #7176

merged 1 commit into from
Jun 7, 2024

Conversation

Khatraf
Copy link
Contributor

@Khatraf Khatraf commented Jun 6, 2024 •
edited
Loading

A reference to the issue / Description of it

#7076

How does this PR fix the problem?

The replication role module has been integrated into the main s3 bucket module so I removed the references to it and updated the source with the new release for the S3 bucket module.

How has this been tested?

Locally.

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

{Please write here}

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

@Khatraf Khatraf requested a review from a team as a code owner June 6, 2024 15:51
@github-actions github-actions bot added the core label Jun 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/environments/core-logging

Running Trivy in terraform/environments/core-logging
2024-06-06T15:53:06Z INFO Need to update DB
2024-06-06T15:53:06Z INFO Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-06-06T15:53:08Z INFO Vulnerability scanning is enabled
2024-06-06T15:53:08Z INFO Misconfiguration scanning is enabled
2024-06-06T15:53:08Z INFO Need to update the built-in policies
2024-06-06T15:53:08Z INFO Downloading the built-in policies...
53.79 KiB / 53.79 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-06-06T15:53:08Z INFO Secret scanning is enabled
2024-06-06T15:53:08Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-06T15:53:08Z INFO Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-06T15:53:10Z INFO Number of language-specific files num=1
2024-06-06T15:53:10Z INFO [gomod] Detecting vulnerabilities...
2024-06-06T15:53:10Z INFO Detected config files num=9

github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf (terraform)

Tests: 7 (SUCCESSES: 6, FAILURES: 0, EXCEPTIONS: 1)
Failures: 0 (HIGH: 0, CRITICAL: 0)

github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=cadab519b10a7d28dfa3b77d407725db6b37614a/main.tf (terraform)

Tests: 13 (SUCCESSES: 12, FAILURES: 0, EXCEPTIONS: 1)
Failures: 0 (HIGH: 0, CRITICAL: 0)

github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=cadab519b10a7d28dfa3b77d407725db6b37614a/replication.tf (terraform)

Tests: 15 (SUCCESSES: 12, FAILURES: 0, EXCEPTIONS: 3)
Failures: 0 (HIGH: 0, CRITICAL: 0)

iam.tf (terraform)

Tests: 12 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 12)
Failures: 0 (HIGH: 0, CRITICAL: 0)

sqs.tf (terraform)

Tests: 4 (SUCCESSES: 3, FAILURES: 0, EXCEPTIONS: 1)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/core-logging

*****************************

Running Checkov in terraform/environments/core-logging
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
2024-06-06 15:53:13,485 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=cadab519b10a7d28dfa3b77d407725db6b37614a:None (for external modules, the --download-external-modules flag is required)
2024-06-06 15:53:13,485 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 490, Failed checks: 0, Skipped checks: 193


checkov_exitcode=0

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/environments/core-logging

*****************************

Running tflint in terraform/environments/core-logging
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output 
*****************************

Trivy will check the following folders:
terraform/environments/core-logging

*****************************

Running Trivy in terraform/environments/core-logging
2024-06-06T15:53:06Z	INFO	Need to update DB
2024-06-06T15:53:06Z	INFO	Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-06-06T15:53:08Z	INFO	Vulnerability scanning is enabled
2024-06-06T15:53:08Z	INFO	Misconfiguration scanning is enabled
2024-06-06T15:53:08Z	INFO	Need to update the built-in policies
2024-06-06T15:53:08Z	INFO	Downloading the built-in policies...
53.79 KiB / 53.79 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-06-06T15:53:08Z	INFO	Secret scanning is enabled
2024-06-06T15:53:08Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-06T15:53:08Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-06T15:53:10Z	INFO	Number of language-specific files	num=1
2024-06-06T15:53:10Z	INFO	[gomod] Detecting vulnerabilities...
2024-06-06T15:53:10Z	INFO	Detected config files	num=9

github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf (terraform)
========================================================================================================================================
Tests: 7 (SUCCESSES: 6, FAILURES: 0, EXCEPTIONS: 1)
Failures: 0 (HIGH: 0, CRITICAL: 0)


github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=cadab519b10a7d28dfa3b77d407725db6b37614a/main.tf (terraform)
========================================================================================================================================
Tests: 13 (SUCCESSES: 12, FAILURES: 0, EXCEPTIONS: 1)
Failures: 0 (HIGH: 0, CRITICAL: 0)


github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=cadab519b10a7d28dfa3b77d407725db6b37614a/replication.tf (terraform)
===============================================================================================================================================
Tests: 15 (SUCCESSES: 12, FAILURES: 0, EXCEPTIONS: 3)
Failures: 0 (HIGH: 0, CRITICAL: 0)


iam.tf (terraform)
==================
Tests: 12 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 12)
Failures: 0 (HIGH: 0, CRITICAL: 0)


sqs.tf (terraform)
==================
Tests: 4 (SUCCESSES: 3, FAILURES: 0, EXCEPTIONS: 1)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

@Khatraf Khatraf closed this Jun 7, 2024
@Khatraf Khatraf reopened this Jun 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/environments/core-logging

Running Trivy in terraform/environments/core-logging
2024-06-07T10:15:05Z INFO Need to update DB
2024-06-07T10:15:05Z INFO Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-06-07T10:15:07Z INFO Vulnerability scanning is enabled
2024-06-07T10:15:07Z INFO Misconfiguration scanning is enabled
2024-06-07T10:15:07Z INFO Need to update the built-in policies
2024-06-07T10:15:07Z INFO Downloading the built-in policies...
53.79 KiB / 53.79 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-06-07T10:15:07Z INFO Secret scanning is enabled
2024-06-07T10:15:07Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-07T10:15:07Z INFO Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-07T10:15:10Z INFO Number of language-specific files num=1
2024-06-07T10:15:10Z INFO [gomod] Detecting vulnerabilities...
2024-06-07T10:15:10Z INFO Detected config files num=9

github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf (terraform)

Tests: 7 (SUCCESSES: 6, FAILURES: 0, EXCEPTIONS: 1)
Failures: 0 (HIGH: 0, CRITICAL: 0)

github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=cadab519b10a7d28dfa3b77d407725db6b37614a/main.tf (terraform)

Tests: 13 (SUCCESSES: 12, FAILURES: 0, EXCEPTIONS: 1)
Failures: 0 (HIGH: 0, CRITICAL: 0)

github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=cadab519b10a7d28dfa3b77d407725db6b37614a/replication.tf (terraform)

Tests: 15 (SUCCESSES: 12, FAILURES: 0, EXCEPTIONS: 3)
Failures: 0 (HIGH: 0, CRITICAL: 0)

iam.tf (terraform)

Tests: 12 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 12)
Failures: 0 (HIGH: 0, CRITICAL: 0)

sqs.tf (terraform)

Tests: 4 (SUCCESSES: 3, FAILURES: 0, EXCEPTIONS: 1)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/core-logging

*****************************

Running Checkov in terraform/environments/core-logging
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
2024-06-07 10:15:13,152 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=cadab519b10a7d28dfa3b77d407725db6b37614a:None (for external modules, the --download-external-modules flag is required)
2024-06-07 10:15:13,152 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 490, Failed checks: 0, Skipped checks: 193


checkov_exitcode=0

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/environments/core-logging

*****************************

Running tflint in terraform/environments/core-logging
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output 
*****************************

Trivy will check the following folders:
terraform/environments/core-logging

*****************************

Running Trivy in terraform/environments/core-logging
2024-06-07T10:15:05Z	INFO	Need to update DB
2024-06-07T10:15:05Z	INFO	Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-06-07T10:15:07Z	INFO	Vulnerability scanning is enabled
2024-06-07T10:15:07Z	INFO	Misconfiguration scanning is enabled
2024-06-07T10:15:07Z	INFO	Need to update the built-in policies
2024-06-07T10:15:07Z	INFO	Downloading the built-in policies...
53.79 KiB / 53.79 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-06-07T10:15:07Z	INFO	Secret scanning is enabled
2024-06-07T10:15:07Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-07T10:15:07Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-07T10:15:10Z	INFO	Number of language-specific files	num=1
2024-06-07T10:15:10Z	INFO	[gomod] Detecting vulnerabilities...
2024-06-07T10:15:10Z	INFO	Detected config files	num=9

github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf (terraform)
========================================================================================================================================
Tests: 7 (SUCCESSES: 6, FAILURES: 0, EXCEPTIONS: 1)
Failures: 0 (HIGH: 0, CRITICAL: 0)


github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=cadab519b10a7d28dfa3b77d407725db6b37614a/main.tf (terraform)
========================================================================================================================================
Tests: 13 (SUCCESSES: 12, FAILURES: 0, EXCEPTIONS: 1)
Failures: 0 (HIGH: 0, CRITICAL: 0)


github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=cadab519b10a7d28dfa3b77d407725db6b37614a/replication.tf (terraform)
===============================================================================================================================================
Tests: 15 (SUCCESSES: 12, FAILURES: 0, EXCEPTIONS: 3)
Failures: 0 (HIGH: 0, CRITICAL: 0)


iam.tf (terraform)
==================
Tests: 12 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 12)
Failures: 0 (HIGH: 0, CRITICAL: 0)


sqs.tf (terraform)
==================
Tests: 4 (SUCCESSES: 3, FAILURES: 0, EXCEPTIONS: 1)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

@Khatraf Khatraf added this pull request to the merge queue Jun 7, 2024
Merged via the queue into main with commit 3837bda Jun 7, 2024
14 checks passed
@Khatraf Khatraf deleted the feature/updating-s3-bucket-source branch June 7, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ep-93 ep-93 ep-93 approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Khatraf @ep-93