-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore markdown files (e.g. README.md) for terraform deployment workflows #7374
Conversation
|
In its current form this feels overdriven to me; setting |
|
An advantage of the existing syntax is that it reads as 'ignore markdown files', irrespective of the directory. Another is that it avoids needlessly bulking out the paths with replication of each path (e.g. for 3 paths here, and 9 paths here <- this last one was added after your comment, as I'd missed that the |
|
A reference to the issue / Description of it
No existing issue. The current github workflows for terraform deployment are triggered on changes within the terraform directories. This includes changes exclusively to
README.md
files, which won't affect the deployment, and shouldn't trigger the workflow.How does this PR fix the problem?
This PR adds a
- '!**.md'
condition to thepaths
argument for the triggering actions (see including and excluding paths syntax). This means that changes to markdown files ending in.md
(i.e. nothtml.md.erb
files) will not trigger these deploy workflows.How has this been tested?
Please describe the tests that you ran and provide instructions to reproduce.
{Please write here}
Deployment Plan / Instructions
Will this deployment impact the platform and / or services on it?
{Please write here}
Checklist (check
x
in[ ]
of list items)Additional comments (if any)
{Please write here}