VEGA-2450 Rename to 'search' to be consistent with blue Sirius #minor #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #518 +/- ##
=======================================
Coverage 72.22% 72.22%
=======================================
Files 111 111
Lines 3788 3788
=======================================
Hits 2736 2736
Misses 740 740
Partials 312 312 ☔ View full report in Codecov by Sentry. |
townxelliot
force-pushed
the
VEGA2450_rename_search_input
branch
from
bcbd81e to
d927545
Compare
The impetus for this is to enable users with assistive technology to say "click search" in both blue and new Sirius and have the search box selected.
townxelliot
force-pushed
the
VEGA2450_rename_search_input
branch
from
d927545 to
3a7fd49
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The impetus for this is to enable users with assistive technology to say "click search" in both blue and new Sirius and have the search box selected.
Checklist