Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added default browser name for tests to the test suite config #45

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aik099
Copy link
Member

@aik099 aik099 commented Nov 5, 2024

This doesn't work, because WEB_FIXTURES_BROWSER in test suite is read using getenv, while other settings are read using $_SERVER.

It is likely related to #44.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.20%. Comparing base (ca55cde) to head (4badcdb).

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #45      +/-   ##
============================================
- Coverage     84.40%   82.20%   -2.21%     
  Complexity      196      196              
============================================
  Files             1        1              
  Lines           500      500              
============================================
- Hits            422      411      -11     
- Misses           78       89      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aik099 aik099 force-pushed the added-browser-name-default branch from bc04dc8 to 4badcdb Compare November 13, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant