-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): tabler-iconsのサブセット化 #15340
Open
kakkokari-gtyih
wants to merge
16
commits into
misskey-dev:develop
Choose a base branch
from
kakkokari-gtyih:feat-tabler-subset
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(frontend): tabler-iconsのサブセット化 #15340
kakkokari-gtyih
wants to merge
16
commits into
misskey-dev:develop
from
kakkokari-gtyih:feat-tabler-subset
+421
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15340 +/- ##
============================================
- Coverage 38.75% 18.87% -19.89%
============================================
Files 1601 762 -839
Lines 204020 110765 -93255
Branches 4012 1231 -2781
============================================
- Hits 79065 20903 -58162
+ Misses 124319 89277 -35042
+ Partials 636 585 -51 ☔ View full report in Codecov by Sentry. |
ready |
やるか |
やった フォントファイル
CSS
|
コンフリクト解消 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
ti-*
クラスを抜き出し、使用されていないアイコンを除いたフォントを生成するように(万が一抜けていてもフルバージョンのファイルにフォールバックされる)Why
クライアント読み込みの高速化
フォントファイル
CSS
Additional info (optional)
ti-${someVar}
のようにアイコン名部分だけを動的に変化させるような書き方をするとアイコンが表示できなくなります(CONTRIBUTING.mdに追記済み)Close #15332
Checklist