-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the interface PerformanceSettings #97
base: main
Are you sure you want to change the base?
Conversation
Maybe it would be better to just provide a simple stub that returns the default values the regular VPhysics exposes...? Do we know of anything that relies on calling SetPerformanceSettings and values actually changing in the system? |
That is what I did initially just for compatibility reasons. I probably should've made the PR then instead, I'll edit it now if you want. When it comes to things relying on SetPerformanceSettings, if the scope of this project is outside just GMod (which has an api call for setting these details, I imagine someone or a mod needing it), there may be another sourcesdk project that would've relied on it. I'm just speculating but it seems reasonable. But again, I'll push a commit to revert the functionality if you'd like. No biggie. |
We can keep the PR around, but I would make one that just stubs it out for now, and we can come back to it if anything ends up depending on it. |
You should do it with the values from regular VPhysics if you do stub it out, to keep behaviour consistent. |
Before I added anything special it behaved just as intended, the values are set by the mod. Will do though, making a new PR. |
I want to tag 0.11 today, so I may beat you to adding a stub here. :b |
You did ;-; |
That last commit was because I forgot to put the actual application of the settings behind the check too. Stylistic choice to guard at the beginning |
Hello yet again,
As per #93 I have fixed the initial issue with the interface returning incorrect values but tried to go and make it work best I could for real rather than storing useless data as a patch. I asked Jorrit from the Jolt repo what out of the parameters was possible to implement and did so (which ended up only being the velocity related parameters). There are also inline functions for each parameter just in case they're ever needed again.