Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes for the updated Hercules Inpulse 300 mappings #14056

Closed
wants to merge 643 commits into from

Conversation

BoredGuy1
Copy link
Contributor

Adds some last-minute edge case handling to #14051, which is a squashed version of #12503 (sorry for the messy commit history).

Original description (edited a bit to reflect recent changes):
I made some improvements to Mixxx's included Inpulse 300 mapping. I tried to stay close to the manufacturer mappings listed in this manual.

Full list of changes:

  • Added ability to stop samplers (shift + button)

  • Added toneplay

    • Pressing a pad jumps to the most recently used hotcue and changes the pitch
    • Shift + toneplay changes the pitch without jumping
    • Pads 1-4 increase the pitch by +0 to +3 semitones
    • Pads 5-8 decrease the pitch by -4 to -1 semitones
    • LED reflects total adjustment to current key
  • Added slicer/slicer loop:

    • Press slicer button to activate a slicer section, press again to deactivate it
    • Slicer length is dependent on loop length
    • Exiting slicer mode or pressing LOOP OUT also deactivates the slicer section
    • Creating a slicer section overrides active loops, and creating a 4-beat loop overrides active slicer sections
    • Only works on constant BPM (also true in native software DJUCED)
    • Slicer section does not move backwards when scratching (also true in native software DJUCED)
  • Added actual beatmatch guide functionality to the LEDs

    • This replaces the LEDs' old end-of-track warning functionality. Hopefully no one missed it :P
  • Changed the way scratching works

    • Wheels have inertia rather than instantly stopping when released (this allows backspins and other tricks)
    • Removed scratchPad in XML (not sure what it was doing there)
  • Fixed some syntax

    • Replaced connectControl with makeConnection to allow multiple connections (and also to comply with newer versions)
    • Replaced "hotcue_X_enabled" with "hotcue_X_status" in XML file to comply with newer version of Mixxx

Manual is being updated accordingly in another PR: PR#604.

daschuer and others added 30 commits September 19, 2024 17:51
fix: remove scaleSignal in waveform analyzer
Add bounds check for m_stemNo in WStemLabel::slotTrackLoaded
Non-floating stem controls for LateNight
fix: sync rate using the current BPM instead of the file one
…eissue

Add missing change, lost in merge 2.5 -> main
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.7 to 4.2.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4.1.7...v4.2.0)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…ns/actions/checkout-4.2.0

Bump actions/checkout from 4.1.7 to 4.2.0
…-rubberband

Fix RubberBand segafult when changing audio setting
CmdlineArgs: Add `--rescan-library` for rescanning on startup
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.4.0 to 4.4.1.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v4.4.0...v4.4.1)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
m0dB and others added 26 commits December 7, 2024 17:58
ci(pre-commit): Add cmake-lint hook
…-autogen

refactor: remove samplew_autogen.h
Controllers: allow to enable MIDI Through Port in non-developer sessions
rendergraph: add rendergraph library
This fixes 
`anonymous namespace not terminated with a closing comment [google-readability-namespace-comments]`
Solves problem with special characters in path to stems
Tooltips: fix cue mode setting location
@BoredGuy1 BoredGuy1 changed the base branch from main to inpulse December 25, 2024 19:41
@BoredGuy1 BoredGuy1 changed the base branch from inpulse to 2.5 December 25, 2024 19:42
@BoredGuy1 BoredGuy1 closed this Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.