Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlists: add 'Unlock all' and 'Delet all unlocked' menu actions #14091

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Dec 31, 2024

Another coffee break feature I found in my git stash.
Kind of fixes #8960

This add two actions to the Playlists context menu (sidebar) like the one we already have in the History feature:

  • Delete all playlists
  • Delete all unlocked playlists

Both need to be confirmed twice.

Will do the same for crates soonish.

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Code Looks good. The workflow can be improved.

I don't like the two popups in a row. It feels as if we don't take user decisions serious.

I would also expect to "allways" respect the Lock.

Let's repeat the pattern of single delete:

  • Only delete unlocked playlists with "one" confirmation.
  • Add a feature to unlock all playlists. If we add a confirm dialog as well. We have still a double safety net.

If you are still concerned about unwanted mass delete. We may add a text input where users need to type "y" for deletion. We may even make it a math challenge "type the result of 4+2"

@ronso0
Copy link
Member Author

ronso0 commented Jan 6, 2025

In History we have two dialogs as well to avoid accidenst. IIRC think you proposed the second one to be a 'summary' so it doesn't come across as "we don't take user decisions serious", which works for me.

image
image

@ronso0
Copy link
Member Author

ronso0 commented Jan 6, 2025

I would also expect to "allways" respect the Lock.
Add a feature to unlock all playlists.

Hmmyeah, that would work for me.
I'll add the 'Unlock all' action and add a "Also delete locked playlists" checkbox.

@ronso0
Copy link
Member Author

ronso0 commented Jan 6, 2025

Otoh, with an 'Unlock all" we can keep "Delete all unlocked playlists" and don't need the "Also delete locked" checkbox.

@ronso0 ronso0 force-pushed the playlists-crates-delete-unlocked branch from dd99efe to e93d07c Compare January 6, 2025 10:28
@ronso0 ronso0 changed the title Playlists: add 'Delete all' and 'Delet all unlocked' menu actions Playlists: add 'Unlock all' and 'Delet all unlocked' menu actions Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete multiple playlists at once
2 participants