Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) WOverview: render progress of analysis triggered by WTrackMenu/AnalysisFeature #14150

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jan 9, 2025

Currently, the analysis progress is rendered in the overview widgets only for analysis triggered when loading a track.
Now it's also rendered when the loaded track is re-analyzed (after clearing the wavefom).

  1. load a new track to a deck (or take an analyzed track all clear waveform, BPM, ReplayGain ..)
    = analysis starts, in overview the analysis progress bar is drawn and waveform is rendered as data is being created
  2. track menu -> Clear -> Waveform
  3. re-analyze (via deck track menu, library track menu or find track in Analyze feature)
    = no progress bar in overview, no feedback <-- fixed, same feedback as with 1.

by-catch of #14140

@ronso0 ronso0 force-pushed the overview-analyis-update branch from f08d7fb to 6d28447 Compare January 9, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant