Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install either libqt6shadertools6-dev or qt6-shadertools-dev #14158

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

daschuer
Copy link
Member

and drop special case for bionic

I don't know why has worked anyway. Maybe an alias or such? But anyway lets try with this.

@daschuer
Copy link
Member Author

This is the run on Ubuntu Noble 24.04 to test the second branch:
https://github.com/daschuer/mixxx/actions/runs/12709469081/job/35428532281

@ronso0 ronso0 changed the title Install either qt6-shadertools-dev or qt6-shadertools-dev Install either libqt6shadertools6-dev or qt6-shadertools-dev Jan 13, 2025
@ronso0
Copy link
Member

ronso0 commented Jan 13, 2025

"libqt6shadertools6-dev or qt6-shadertools-dev" is correct, want to rephrase the commit?
And maybe even split this into two commits?

@daschuer daschuer added this to the 2.5.1 milestone Jan 14, 2025
@daschuer
Copy link
Member Author

Done

Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤷

@ronso0 ronso0 merged commit 1ab8b13 into mixxxdj:2.5 Jan 14, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants