LateNight facelift pt. III

[ronso0]

🛵 here we go...

This is still WIP (see ToDo below), but please comment if you find any other bugs.
I'll force-push every now and then. Changes are mostly intertwined, and sorting them into commits takes more time than the actual changes.

Usability extensions:

• Play / Cue moved to the left side of decks (Zulip topic, lp:1876000)
• changed Mic / Aux order and order of controls inside units accordingly
• hide the Mixer to choose among three deck sizes, showing the mixer automatically switches back to regular decks:
  • FULL for all controls
  • Compact for reduced height, no hotcues, no intro/outro cues, basic loop controls only, no speed adjust buttons
  • mini as above the maximized library
• overhauled Fx rack: with 4 Fx units, diagonally opposing units (1 / 4, 2 / 3) can expand without stretching the entire fx rack
• Waveforms toggle in toolbar
• knobs have arcs (PaleMoon theme)
• sliders have level bars (PaleMoon theme)
• added OpenSans-semibold to have less heavy deck labels

ToDo (functional)

• fix spacers in Mic / Aux rack
• with Medium decks, add option to show VU meters where the Mixer was
• skin settings menu: improve deck size row
• skin settings menu: separate options for full & compact decks
• use CamelCase for all variables
• make entire Artist / Title section track drop target, work around https://bugs.launchpad.net/mixxx/+bug/1879584)
• check what fits into minimal samplers: BPM, eject, xfader selector
• use individual font size in each overview type
• asure all changes from Skins :: separate play button / play_indicator + related improvements #2619 are included

ToDo (style)

• find a better font for deck labels & numbers postponed, added OpenSans-semibold
• re-align Library icons with pixel grid
• restore styles for Classic theme
• add PaleMoon theme with dimmed (desaturated) colors
• adapt & fix remove Flip theme
• double check Classic library
• style Effect focus widgets
• clean up css
• fix open Effect selector on Windows
• update skin preview images

NiceToHave

• more samplers? 4 / 8 / 16
• beatsize spinboxes & key display: have up/down buttons side by sidefor better accessibility
• indicate which Fx unit is currently active on controller via [FxRack1_FxUnitN],controller_input_active
• restore BananaFlip theme
• align deck & master Vu meters in 4-deck mixer
• in collapsed fx units, show parameters of focused effect below effect toggles
• with 2 Fx units in the GUI and 4 units mapped to controller, show only the unit which is active on the controller

[ronso0]

Please no comments about Flip theme, yet. That's probably broken after recent changes.

[uklotzde]

Once our waveforms are fixed Mixxx will have the slickest UI of all!

I would use Late Night again if I could replace the dark yellow text color with that from the table headers.

[ronso0]

I would use Late Night again if I could replace the dark yellow text color with that from the table headers.

I have a Pale theme in mind where the indicators a less bright and all text labels are some kind of bright grey. The stylesheet could be really compact.
Until then, https://github.com/mixxxdj/mixxx/pull/2736/files#diff-6761a9e770568e999bffff10ea18bf5cR217 find color: #f0bb2b; in style.qss somewehere around line 217 and change it to #bbb (header font color).

[nopeppermint]

Hi @ronso0

• I do not know if this is intended but the bpm on the minimal samplers are no longer visible, for me this is a key element.

• the background for even/uneven lines in the library is much worse, it no longer clear visible and I prefer the old text color and style
  

[ronso0]

Yes, finding the right text colors is tricky.
Until now I worked on the skins with an 2012 1366px TN-panel (low brightness, washy contrast), which is why I find Deere too pale for example.

Now I tried it on a 2019 FHD IPS screen and the contrasts are way too dazzling, especially in a dark setting.

I'm confident we can satisfy all demands with some very compact color schemes that just set bg colors, indicator colors and some text colors. if qss stylesheets would accept variables that would be awesome as it would make the design process so much simpler, just one place to set each color..

[ronso0]

btw it's not clear to me why (besides Classic & Flip) I see a third, empty scheme in Pref > Interface > Color Scheme.

[JoergAtGithub]

This looks great!
Let me sugest, to reduce the column width for Cover Art in the library: Set it to the same value as the row height, because all covers are squares by nature. It will be easier to recognize them, if you see them full but small, than the top 20% in medium size. And it will save table space.

[Be-ing]

The library column setup is independent of the skin. You can adjust the width of each column as you like by dragging and dropping the boundaries of the columns in the table header.

[Holzhaus]

You see, if we add yet 3 more colors for EQ ranges the knob colors would rather create confusion than help in any way.

I agree.

[ronso0]

you may have noticed I'm about to iron out the very very last small issues ;)

@Holzhaus Would you mind sharing a 4k screenshot with full config?
4 decks, beatgrid controls, fx, samplers, mic & AutoDJ

[Swiftb0y]

You see, if we add yet 3 more colors for EQ ranges the knob colors would rather create confusion than help in any way.

In addition, that would only make sense if people use the RGB waveforms so when using filtered waveforms, the colors on the EQ would make no sense at all.

[Holzhaus]

@Holzhaus Would you mind sharing a 4k screenshot with full config?
4 decks, beatgrid controls, fx, samplers, mic & AutoDJ

Here are some screenshots:

[ronso0]

Thanks!
Seems everything was pushed correctly, except the WBetaSpinbox borders aren't update for you as well. I'll take a look.

[ywwg]

This is looking really good still!

[Holzhaus]

Ready to merge? We can still fix things later on in another PR.

Maybe we can make the hotcue popup menu look better by reusing the assets and fonts (e. g. to make the color buttons more like hotcue buttons), but if we do that it should go in a separate PR.

[ronso0]

✓ layout switching works and is persistent
✓ controls look okay
✓ icon scheme works
Yep, ready for merge! I'll add the preview image now

[ronso0]

Ready for takeoff !!

[Holzhaus]

The skin preview image does not show, it needs to be a PNG, not a JPG.

[ronso0]

hehe..whoopsy.
fixed.

[Holzhaus]

Looks great, thank you very much!

[Holzhaus]

Can you make a blogpost for mixxxdj/website#77 that showcases the awesome skin improvements for the 2.3 release?