Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise minimum macOS version to 11 (Qt6.5 requirement) and use AVX instruction set #142

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

JoergAtGithub
Copy link
Member

@JoergAtGithub JoergAtGithub commented Mar 29, 2024

The 2.5 buildenv contains Qt6.5, which has macOS 11 as minimum system requirement: https://doc.qt.io/qt-6.5/supported-platforms.html#desktop-platforms

Therefore I raised the mimimum required macOS version to 11.0.

The x86_64 computer models supported by macOS 11 are very limited, I checked, that each of them has a processor with AVX instruction set. Therefore AVX is set as default for macOS now.

I've no Mac myself and can't verify/measure that the setting does, what it should.

Raised processor instruction set to AVX, because all macOS 11 supported Apple models have AVX.
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer daschuer merged commit 0d6dec6 into mixxxdj:2.5 Apr 9, 2024
3 checks passed
@JoergAtGithub JoergAtGithub deleted the macOS11_AVX branch April 10, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants