Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add liblo to the feature list #146

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Add liblo to the feature list #146

merged 3 commits into from
Oct 3, 2024

Conversation

daschuer
Copy link
Member

No description provided.

@daschuer
Copy link
Member Author

I have cleaned the history. I consider this a small addition that it does not rectify to fork a 2.6 branch. Having this merged releases us from some maintenance when developing the OSC interface. What do you think?

@daschuer
Copy link
Member Author

daschuer commented Aug 28, 2024

@fwcd Can you verify this as well? Here I have picked explicit Xcode_13.1 Without it it would default to Xcode 14.2. What would be best? (This is currently used for the 2.5 and main (2.6) branch)

@fwcd
Copy link
Member

fwcd commented Aug 28, 2024

If it builds, I'd say this looks good. Not bumping Xcode too far on 2.5 is probably a good idea in terms of risk, even though in principle it shouldn't matter. Same goes for making sure we use the same Xcode version here and in the mixxx repo.

@daschuer
Copy link
Member Author

Currently we use an environment that has been build on older macOS and Xcode. In the mixxx repository we are on Xcode 14.2. So this is already an issue if it is an issue.

@fwcd
Copy link
Member

fwcd commented Aug 28, 2024

Ah okay, then I see no reason why this should be an issue

@daschuer
Copy link
Member Author

daschuer commented Oct 2, 2024

@fwcd can this be merged?

@fwcd
Copy link
Member

fwcd commented Oct 2, 2024

I think so, yes

@daschuer
Copy link
Member Author

daschuer commented Oct 3, 2024

Ok, than let's merge.

@daschuer daschuer merged commit cf3cdc7 into 2.5 Oct 3, 2024
6 checks passed
@daschuer daschuer deleted the liblo branch January 14, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants