Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crazyhouse fix and engine toggle fix #275

Merged
merged 5 commits into from
May 17, 2024

Conversation

ksthicke
Copy link
Contributor

Purpose

Fixes #257 as described in my comment there.
Also fixes an issue with the engine toggle not always working.

Pre-merge TODOs and Checks

  • PGN file loads correctly
  • Navigating through the move history works
  • Starting the engine shows moves (test for both sides)
  • Selecting a different variant loads a new board with the variant and you can make moves on the board
  • In Crazyhouse the pocket pieces are shown and you can drop pieces

@ksthicke ksthicke changed the title Crazyhouse Crazyhouse fix and engine toggle fix May 17, 2024
@QueensGambit QueensGambit merged commit b0f8e65 into ml-research:master May 17, 2024
1 check passed
@QueensGambit
Copy link
Collaborator

Great, thanks again @ksthicke for fixing this issue.
I agree that passing movetime 60000 to the engine directly is a cleaner solution.

@ksthicke ksthicke deleted the crazyhouse branch May 19, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unwanted changes of board position after a move
2 participants