Fix for dev httr2 #130
Merged
Fix for dev httr2 #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
httr2 has switched to a more aggressive URL parser which now throws an error, so I've made the minimal fix to get your tests passing again The proposed code should work with both old and new httr2, so you can submit to CRAN now, if you want. I am planning to submit httr2 to CRAN on Jan 17, so you'll have to submit ~2 weeks after this date. \
5 tasks
|
Thanks for the PR and the heads up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
httr2 has switched to a more aggressive URL parser which now throws an error, so I've made the minimal fix to get your tests passing again The proposed code should work with both old and new httr2, so you can submit to CRAN now, if you want. I am planning to submit httr2 to CRAN on Jan 17, so you'll have to submit ~2 weeks after this date. \