Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add className prop to all layers #353

Closed
wants to merge 3 commits into from

Conversation

ludvigeriksson
Copy link

The className prop was missing (defined as the first prop here: https://openlayers.org/en/latest/apidoc/module-ol_layer_Base-BaseLayer.html), so I added it to all layers.

@mmomtchev
Copy link
Owner

@ludvigeriksson this is missing unit tests

I switched to the official codecov action, you can try rebasing and it should start working for PRs

@ludvigeriksson
Copy link
Author

@mmomtchev Will it be merged if I add unit tests? My previous PR (#277) didn't.

@mmomtchev
Copy link
Owner

If you add unit tests that cover the added code and all the unit tests work, yes it will get merged. If you insist on posting comments simultaneously with other persons involved in the extortion, it will still get merged, however I will say it loud and clear.

@ludvigeriksson
Copy link
Author

This is the second time you have accused me of extortion when I'm trying to contribute to your open source project that you have chosen to publish. Since you clearly are not interested in driving this repo in a professional manner, I will continue working on my own fork instead. I wish you all the best in the future, and thank you for the ground you have laid in this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants