MAINT: Update Azure #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, looks like we never set up the Azure pipeline for this repo. I've done it now: |
adam2392
reviewed
Feb 11, 2022
Comment on lines
+273
to
+277
| # TODO: This is wrong -- it averages in the complex domain (over tapers). | ||
| # What it *should* do is compute the conn for each taper, then average | ||
| # (see below). | ||
| if collapse is not None: | ||
| out = np.mean(out, axis=collapse) |
There was a problem hiding this comment.
I see. Thanks for this comment. Perhaps that is why there are some issues in #73
adam2392
approved these changes
Feb 11, 2022
|
Should we add a badge to the README to indicate testing is done for Windows? |
Feel free -- I think you can take it from MNE-Python. (Azure badge usually indicates Windows support I think.) Feel free to merge this if you're happy @adam2392 and also open an issue for the TODO... I really just wanted to update |
tsbinns
pushed a commit
to tsbinns/mne-connectivity
that referenced
this pull request
Dec 15, 2023
* MAINT: Update Azure * FIX: Make it work, badly * FIX: GL * FIX: Fixes * FIX: Doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for https://devblogs.microsoft.com/devops/hosted-pipelines-image-deprecation/#windows