Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add MEGnet to make MNE-ICALabel work on MEG data #207
base: main
Are you sure you want to change the base?
add MEGnet to make MNE-ICALabel work on MEG data #207
Changes from all commits
ec28e4f
6f272b1
b3433c8
34c2f31
5b7dc9c
96ed02d
989cb40
bc64aa2
8af24b1
8f5e0e6
5aabe3f
bd7f8cc
59aedfb
067849c
a0da5ee
143df13
58a719a
b89c864
8465017
a0e526d
40b1074
49f39d1
4f2d43a
bbce3cc
19e0260
c47d582
686fda1
c5897e1
88d0619
7d0a7e2
25824fb
036599b
30cc94a
7922f2f
ce6e82c
4c672b2
401740d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this line causes issues.
See:
mne-icalabel/mne_icalabel/iclabel/network/onnx.py
Line 27 in 43eec6d
Let us know if that doesn't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think he modified anything from
iclabel
, that should not be failing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes nvm. I misread the error.
Hmm it seems the file is somehow not found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I found the issue! After I added the
__init__.py
file in themne_icalabel/megnet
directory, it was able to correctly findmegnet.onnx
. (but I remember that python(at least v3.8) don't require init.py to treat a folder as a package.)