Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: branch name compliance [DEVOP-147] #92

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Conversation

callms
Copy link
Contributor

@callms callms commented Mar 12, 2024

What does it do? Why?

There is a (probably too) long discussion on #mobsuccess-architecture regarding branch names.

Facts:

  • ADR #9 was meant to further restrict branch names;
  • however, it is written in a way that only restricts Pull Requests title, and allow further extension of branch names;
  • the Mobsuccess Policy GHA was updated but still referenced the Notion page and not the ADR.

This ADR is non-opiniated and has the only purpose of reflecting the current state of decisions that were already made.

Along with changes in this repository, I have also updated the Notion page to emphasize that ADR #9 is the main source of truth, and removed text that no longer reflected our Git usage (like, how we merged before merge queue).

@github-actions github-actions bot added the fix Bug Fix label Mar 12, 2024
@callms callms changed the title fix: branch name compliance fix: branch name compliance [DEVOP-147] Mar 12, 2024
@callms callms force-pushed the fix/branch-name-compliance branch from 34d2f14 to 7db67b0 Compare March 12, 2024 13:43
@callms callms merged commit 5d71cc0 into master Mar 12, 2024
6 checks passed
@callms callms deleted the fix/branch-name-compliance branch March 12, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant