Merge pull request #427 from hugopeek/master

Fix undefined array key "service" warnings
modmore · Mar 16, 2023 · 1653c33 · 1653c33
2 parents 0725764 + 3803232
commit 1653c33
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/src/Command/BuildCommand.php b/src/Command/BuildCommand.php
@@ -209,12 +209,12 @@ public function getPackage($package, array $options = array())
             $path .= 'model/';
         }
 
-        if ($options['service']) {
+        if (isset($options['service'])) {
             $path .= $package . '/';
             $this->modx->getService($package, $options['service'], $path);
-	} else {
-	    $this->modx->addPackage($package, $path);
-	}
+        } else {
+            $this->modx->addPackage($package, $path);
+        }
     }
 
     /**

diff --git a/src/Command/ExtractCommand.php b/src/Command/ExtractCommand.php
@@ -324,12 +324,12 @@ public function getPackage($package, array $options = array())
             $path .= 'model/';
         }
 
-	if ($options['service']) {
-	    $path .= $package . '/';
-	    $this->modx->getService($package, $options['service'], $path);
-	} else {
-	    $this->modx->addPackage($package, $path);
-	}
+        if (isset($options['service'])) {
+            $path .= $package . '/';
+            $this->modx->getService($package, $options['service'], $path);
+        } else {
+            $this->modx->addPackage($package, $path);
+        }
     }
 
     /**