Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stdlib] [NFC] Fix revert python format with ruff inside stdlib folder #3822

Conversation

martinvuyk
Copy link
Contributor

@martinvuyk martinvuyk commented Nov 28, 2024

Revert d6fdf0c , which used ruff formatter that is not the same as the mojo black formatter fork (I assume that's what was forked). It was making the public CI fail.

CC @keith

Signed-off-by: martinvuyk <[email protected]>
@martinvuyk martinvuyk requested a review from a team as a code owner November 28, 2024 13:50
@martinvuyk martinvuyk changed the title [stdlib] Revert d6fdf0cac5a987c030f5bc4da0f0bd9ba0ff112e [stdlib] Revert python format with ruff inside stdlib folder Nov 28, 2024
@martinvuyk martinvuyk changed the title [stdlib] Revert python format with ruff inside stdlib folder [stdlib] [NFC] Fix revert python format with ruff inside stdlib folder Nov 28, 2024
@keith
Copy link
Contributor

keith commented Dec 2, 2024

thanks for cc'ing me! I submitted #3832 to use ruff on CI as well

@martinvuyk martinvuyk closed this Dec 2, 2024
@martinvuyk martinvuyk deleted the revert-d6fdf0cac5a987c030f5bc4da0f0bd9ba0ff112e branch December 2, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants