[stdlib] Fix startswith() and endswith()
#3922
Open
+52
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
martinvuyk
changed the title
startswith() and endswith()startswith() and endswith()
|
@JoeLoser @ConnorGray @jackos @lsh pinging all of you to see if anyone can expedite this so that the public CI doesn't keep failing |
|
!sync |
modularbot
added
the
imported-internally
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
the
merged-internally
modularbot
pushed a commit
that referenced
this pull request
Jan 11, 2025
Improve `startswith()` and `endswith()` This changes these methods to take `StringSlice`, and simplifies their implementation on `String` and `StringLiteral` to simply delegate to `StringSlice`'s implementation of the same operation. Closes #3903. Solves the current CI failure with `check_licences.mojo` passing a `StringSlice` to `String.startswith()`. Co-authored-by: Connor Gray <[email protected]> Closes #3922 MODULAR_ORIG_COMMIT_REV_ID: 8b078da9d23edc4e118dc9854763e0fb69887fba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
startswith()andendswith()Closes #3903
Solves the current CI failure with
check_licences.mojopassing aStringSlicetoString.startswith()