Skip to content

Commit

Permalink
fix(ci): bad MINIO_STORAGE_REGION env var
Browse files Browse the repository at this point in the history
  • Loading branch information
tsa96 committed Oct 19, 2024
1 parent 434f8de commit 605c36d
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
2 changes: 2 additions & 0 deletions apps/backend-e2e/src/support/global-setup.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ async function nukeDB() {
}

async function nukeS3() {
// secure!!
console.log(process.env);

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information High

This logs sensitive data returned by
process environment
as clear text.
const s3 = new S3Client({
region: process.env.STORAGE_REGION,
endpoint: process.env.STORAGE_ENDPOINT_URL,
Expand Down
3 changes: 2 additions & 1 deletion commitlint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ module.exports = {
'formats',
'discord',
'twitch',
'prod'
'prod',
'ci'
]
],
'subject-case': [
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ services:
POSTGRES_PASSWORD: root
POSTGRES_PORT: 5432
DATABASE_URL: postgresql://root:root@postgres/momentum?schema=public
MINIO_SITE_REGION: us-west-1
MINIO_SERVER_PORT: 9000
MINIO_CONSOLE_PORT: 9001
MINIO_ROOT_USER: minio
Expand All @@ -25,7 +26,6 @@ services:
STEAM_WEB_API_KEY: thisisenoughtogenerateanopenidreferralforsomereason
SESSION_SECRET: thisisashitsecretdontuseitinprod
JWT_SECRET: thisisalsonotasecure
MINIO_SITE_REGION: ${STORAGE_REGION}
ports:
- "5432:5432"
minio:
Expand Down

0 comments on commit 605c36d

Please sign in to comment.