fix(back): incorrect pino loglevel default value handling

momentum-mod · Sep 27, 2024 · d2b070f · d2b070f
1 parent 5c9f6d8
commit d2b070f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/apps/backend/src/app/app.module.ts b/apps/backend/src/app/app.module.ts
@@ -1,6 +1,6 @@
 import { Module } from '@nestjs/common';
 import { APP_FILTER, APP_INTERCEPTOR } from '@nestjs/core';
-import { LoggerModule } from 'nestjs-pino';
+import { LoggerModule, Params as PinoParams } from 'nestjs-pino';
 import { ConfigModule, ConfigService } from '@nestjs/config';
 import { FastifyMulterModule } from '@nest-lab/fastify-multer';
 import { ExceptionHandlerFilter } from './filters/exception-handler.filter';
@@ -35,7 +35,7 @@ import { setupNestInterceptor } from '../instrumentation';
     // all HTTP requests (so no need for a Nest interceptor).
     // In dev mode, outputs as more human-readable strings using `pino-pretty`.
     LoggerModule.forRootAsync({
-      useFactory: async (config: ConfigService) => ({
+      useFactory: async (config: ConfigService): Promise<PinoParams> => ({
         pinoHttp: {
           customProps: (_req, _res) => ({ context: 'HTTP' }),
           level: config.getOrThrow('logLevel'),

diff --git a/apps/backend/src/app/config/config.ts b/apps/backend/src/app/config/config.ts
@@ -69,9 +69,8 @@ export const ConfigFactory = (): ConfigInterface => {
       maxCreditsExceptTesters: MAX_CREDITS_EXCEPT_TESTERS,
       preSignedUrlExpTime: PRE_SIGNED_URL_EXPIRE_TIME
     },
-    logLevel: ((process.env['LOG_LEVEL'] ?? isTest)
-      ? 'warn'
-      : 'info') as pino.LevelWithSilent
+    logLevel: (process.env['LOG_LEVEL'] ??
+      (isTest ? 'warn' : 'info')) as pino.LevelWithSilent
   };
 };