Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(front): Fixed sorting when grouping leaderboards #1090

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

GordiNoki
Copy link
Member

Closes #1084

Makes sorting for leaderboard grouping definitive. Looks like chrome and firefox array sort implementations are a bit different, where first and second argument for sort function are switched. The issue is not just with firefox and based on how leaderboards are sorted initially when created (which is also affected by what browser map is submitted from)

Screenshots (if applicable)

изображение
изображение

Checks

  • !! DONT IGNORE ME !! I have ran nx run db:create-migration <name> and committed the migration if I've made DB schema changes
  • I have included/updated tests where applicable (see Testing)
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits

@GordiNoki GordiNoki requested a review from tsa96 January 9, 2025 16:51
Copy link
Member

@tsa96 tsa96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, had no idea ECMA spec was so loose on this.

@tsa96 tsa96 merged commit 8c1d355 into main Jan 10, 2025
7 checks passed
@tsa96 tsa96 deleted the fix/leaderboards-sort branch January 10, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map leaderboards broken in Firefox
2 participants