Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE: Address qc-duplicate-exact-synonym-no-abbrev failures in mondo - build #755

Draft
wants to merge 2 commits into
base: qc-duplicate-exact-synonym-no-abbrev
Choose a base branch
from
Draft

DO NOT MERGE: Address qc-duplicate-exact-synonym-no-abbrev failures in mondo - build #755

wants to merge 2 commits into from

Conversation

joeflack4
Copy link
Contributor

@joeflack4 joeflack4 mentioned this pull request Jan 16, 2025
Open
9 tasks
@joeflack4 joeflack4 marked this pull request as draft January 16, 2025 20:30
@joeflack4 joeflack4 self-assigned this Jan 16, 2025
@joeflack4 joeflack4 added the build Mostly for build PRs: when changes only to data files post `build-mondo-ingest`; no code changes label Jan 16, 2025
@joeflack4 joeflack4 force-pushed the qc-duplicate-exact-synonym-no-abbrev--build branch from 145c019 to 7f159e3 Compare January 17, 2025 03:06
@joeflack4 joeflack4 requested a review from twhetzel January 17, 2025 03:53
@joeflack4 joeflack4 force-pushed the qc-duplicate-exact-synonym-no-abbrev--build branch from 7f159e3 to 016ff3e Compare January 17, 2025 03:53
joeflack4
joeflack4 commented Jan 17, 2025
View reviewed changes
Copy link
Contributor Author

@joeflack4 joeflack4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build looks good, and these results were used to get QC to pass in:

joeflack4
joeflack4 commented Jan 23, 2025
View reviewed changes
Copy link
Contributor Author

@joeflack4 joeflack4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Also what I wrote in the mini-build, confirmed working as attended via QC check in mondo:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twhetzel twhetzel Awaiting requested review from twhetzel

Assignees

@joeflack4 joeflack4

Labels
build Mostly for build PRs: when changes only to data files post `build-mondo-ingest`; no code changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joeflack4